From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: [Intel-gfx] [PATCH v3] drm/i915: Run relevant bits of debugfs drop_caches per GT
Date: Thu, 7 Sep 2023 14:58:08 +0200 [thread overview]
Message-ID: <20230907125808.186088-1-andi.shyti@linux.intel.com> (raw)
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Walk all GTs when doing the respective bits of drop_caches work.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
Hi,
I'm proposing this new version of the series I sent here[*].
Patch 1 from that series is not necessary so taht I'm going to
propose the original version proposed by Tvrtko when we were
young.
Andi
Changelog
=========
v2 -> v3:
- fix the "for_each_gt()" parameter order.
v1 -> v2:
- drop the gt idling and the cache flushing decoupling and stick
to the original version.
[*] https://patchwork.freedesktop.org/series/123301/
drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7a90a2e32c9f1..e9b79c2c37d84 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -740,15 +740,19 @@ static int
i915_drop_caches_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
+ struct intel_gt *gt;
unsigned int flags;
+ unsigned int i;
int ret;
drm_dbg(&i915->drm, "Dropping caches: 0x%08llx [0x%08llx]\n",
val, val & DROP_ALL);
- ret = gt_drop_caches(to_gt(i915), val);
- if (ret)
- return ret;
+ for_each_gt(gt, i915, i) {
+ ret = gt_drop_caches(gt, val);
+ if (ret)
+ return ret;
+ }
fs_reclaim_acquire(GFP_KERNEL);
flags = memalloc_noreclaim_save();
--
2.40.1
next reply other threads:[~2023-09-07 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 12:58 Andi Shyti [this message]
2023-09-07 13:47 ` [Intel-gfx] [PATCH v3] drm/i915: Run relevant bits of debugfs drop_caches per GT Rodrigo Vivi
2023-09-08 22:23 ` Andi Shyti
2023-09-07 13:49 ` Nirmoy Das
2023-09-07 19:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Run relevant bits of debugfs drop_caches per GT (rev2) Patchwork
2023-09-07 21:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-08 1:28 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Run relevant bits of debugfs drop_caches per GT (rev3) Patchwork
2023-09-08 1:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-08 5:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-08 7:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Run relevant bits of debugfs drop_caches per GT (rev4) Patchwork
2023-09-08 12:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-08 15:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Run relevant bits of debugfs drop_caches per GT (rev5) Patchwork
2023-09-08 21:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907125808.186088-1-andi.shyti@linux.intel.com \
--to=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox