From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, gregkh@linuxfoundation.org, mcgrof@kernel.org,
daniel.vetter@ffwll.ch
Cc: linux-doc@vger.kernel.org, jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, Jim Cromie <jim.cromie@gmail.com>,
seanpaul@chromium.org, dri-devel@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v6 18/22] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED
Date: Mon, 11 Sep 2023 17:08:34 -0600 [thread overview]
Message-ID: <20230911230838.14461-19-jim.cromie@gmail.com> (raw)
In-Reply-To: <20230911230838.14461-1-jim.cromie@gmail.com>
Reserve bit 7 to remember that a pr-debug callsite is/was:
- enabled, with +p
- wants a dynamic-prefix, with one+ of module:function:sourcfile
- was previously called
- was thus saved in the cache. NOT YET.
Its unclear whether any cache fetch would be faster than 2-3 field
fetches, but theres another factor; the 3 columns in the __dyndbg
section are highly redundant and compressible, but to get the
compression, we need field accessors, which will rebalance the
tradeoff.
So, for now, its just the bit reservation.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 15edac27cb56..bdb0d12b13ec 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -38,6 +38,7 @@ struct _ddebug {
#define _DPRINTK_FLAGS_INCL_LINENO (1<<3)
#define _DPRINTK_FLAGS_INCL_TID (1<<4)
#define _DPRINTK_FLAGS_INCL_SOURCENAME (1<<5)
+#define _DPRINTK_FLAGS_PREFIX_CACHED (1<<7)
#define _DPRINTK_FLAGS_INCL_ANY \
(_DPRINTK_FLAGS_INCL_MODNAME | _DPRINTK_FLAGS_INCL_FUNCNAME |\
--
2.41.0
next prev parent reply other threads:[~2023-09-11 23:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 23:08 [Intel-gfx] [PATCH v6 00/22] fix DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 01/22] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 02/22] dyndbg: make ddebug_class_param union members same size Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 03/22] dyndbg: replace classmap list with a vector Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 04/22] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 05/22] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 06/22] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 07/22] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 08/22] dyndbg: silence debugs with no-change updates Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 09/22] dyndbg: tighten ddebug_class_name() 1st arg type Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 10/22] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 11/22] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 12/22] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 13/22] dyndbg: add for_each_boxed_vector Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 14/22] dyndbg: refactor ddebug_classparam_clamp_input Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 15/22] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 16/22] dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 17/22] dyndbg-doc: add classmap info to howto Jim Cromie
2023-09-11 23:08 ` Jim Cromie [this message]
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 19/22] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 20/22] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 21/22] drm: use correct ccflags-y spelling Jim Cromie
2023-09-11 23:08 ` [Intel-gfx] [PATCH v6 22/22] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-09-11 23:35 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for fix DRM_USE_DYNAMIC_DEBUG regression Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911230838.14461-19-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jbaron@akamai.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox