From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: andi.shyti@intel.com, chris.p.wilson@linux.intel.com,
tomasz.mistat@intel.com, jonathan.cavitt@intel.com,
rodrigo.vivi@intel.com, gregory.f.germano@intel.com,
matthew.d.roper@intel.com, nirmoy.das@intel.com
Subject: [Intel-gfx] [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123
Date: Wed, 20 Sep 2023 14:07:00 -0700 [thread overview]
Message-ID: <20230920210704.3624771-1-jonathan.cavitt@intel.com> (raw)
Apply Wa_16018031267 / Wa_16018063123. This necessitates submitting a
fastcolor blit as WABB and setting the copy engine arbitration to
round-robin mode.
v2:
- Rename old platform check in second patch to match
declaration in first patch.
- Refactor second patch name to match first patch.
v3:
- Move NEEDS_FASTCOLOR_BLT_WABB to intel_gt.h.
- Refactor NEEDS_FASTCOLOR_BLT_WABB to make it more
streamlined to use.
- Stop dividing PAGE_SIZE by sizeof(u32) when computing
ctx_bb_ggtt_addr for lrc_setup_bb_per_ctx.
- Reduce comment complexity.
- Fix several checkpatch warnings.
v4:
- Actually stop dividing PAGE_SIZE by sizeof(u32) when
computing ctx_bb_ggtt_addr for lrc_setup_bb_per_ctx.
v5:
- Stop dividing PAGE_SIZE by sizeof(u32) in
check_ring_start during lrc live selftest.
v6:
- Append MI_BATCH_BUFFER_END to end of all PER_CTX_BB
command streams.
- No longer skip on empty, as command stream will never
be empty (always contains at least MI_BATCH_BUFFER_END).
- No longer append MI_NOOP until cachline aligned (was a
fragment from INDIRECT_CTX setup).
v7:
- Use 0x6b instead of 0 for color to maintain functionality.
v8:
- Revert v7.
- Add some reserved kernel space per vm to run the
workaround on.
v9:
- Hide reserved kernel space per vm from userspace.
v10:
- Revert v7 properly.
- Test on updated IGT.
v11:
- Remove Test-with tag.
- Reserve two pages per vm for workaround.
v12:
- Use Null page for scratch page.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: Tomasz Mistat <tomasz.mistat@intel.com>
CC: Gregory F Germano <gregory.f.germano@intel.com>
CC: Matt Roper <matthew.d.roper@intel.com>
CC: James Ausmus <james.ausmus@intel.com>
CC: Chris Wilson <chris.p.wilson@linux.intel.com>
CC: Andi Shyti <andi.shyti@intel.com>
Jonathan Cavitt (4):
drm/i915: Enable NULL PTE support for vm scratch
drm/i915: Reserve some kernel space per vm
drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123
drm/i915: Set copy engine arbitration for Wa_16018031267 /
Wa_16018063123
.../drm/i915/gem/selftests/i915_gem_context.c | 6 ++
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 10 ++
drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++
drivers/gpu/drm/i915/gt/intel_gt.h | 4 +
drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 +
drivers/gpu/drm/i915/gt/intel_gtt.h | 2 +
drivers/gpu/drm/i915/gt/intel_lrc.c | 100 +++++++++++++++++-
drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +
drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++----
drivers/gpu/drm/i915/i915_drv.h | 2 +
drivers/gpu/drm/i915/i915_pci.c | 2 +
drivers/gpu/drm/i915/intel_device_info.h | 1 +
12 files changed, 184 insertions(+), 21 deletions(-)
--
2.25.1
next reply other threads:[~2023-09-20 21:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 21:07 Jonathan Cavitt [this message]
2023-09-20 21:07 ` [Intel-gfx] [PATCH v12 1/4] drm/i915: Enable NULL PTE support for vm scratch Jonathan Cavitt
2023-10-18 13:11 ` Andrzej Hajda
2023-09-20 21:07 ` [Intel-gfx] [PATCH v12 2/4] drm/i915: Reserve some kernel space per vm Jonathan Cavitt
2023-10-18 13:17 ` Andrzej Hajda
2023-09-20 21:07 ` [Intel-gfx] [PATCH v12 3/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 Jonathan Cavitt
2023-10-18 13:24 ` Andrzej Hajda
2023-10-18 13:39 ` Nirmoy Das
2023-09-20 21:07 ` [Intel-gfx] [PATCH v12 4/4] drm/i915: Set copy engine arbitration " Jonathan Cavitt
2023-10-18 13:26 ` Andrzej Hajda
2023-09-21 2:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply " Patchwork
2023-09-21 2:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-21 2:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-21 9:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-22 2:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev2) Patchwork
2023-09-22 2:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-22 3:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-23 4:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev3) Patchwork
2023-09-23 4:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-23 4:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-24 8:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-17 13:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Apply Wa_16018031267 / Wa_16018063123 (rev5) Patchwork
2023-10-17 13:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-17 13:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-17 18:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920210704.3624771-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=andi.shyti@intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=gregory.f.germano@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tomasz.mistat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox