public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
	gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: lb@semihalf.com, groeck@google.com, linux-doc@vger.kernel.org,
	jani.nikula@intel.com, daniel.vetter@ffwll.ch,
	linux@rasmusvillemoes.dk, rostedt@goodmis.org,
	Jim Cromie <jim.cromie@gmail.com>,
	mcgrof@kernel.org, seanpaul@chromium.org, joe@perches.com,
	bleung@google.com, yanivt@google.com
Subject: [Intel-gfx] [PATCH v7c 17/24] dyndbg-doc: add classmap info to howto
Date: Wed, 18 Oct 2023 11:05:57 -0600	[thread overview]
Message-ID: <20231018170604.569042-18-jim.cromie@gmail.com> (raw)
In-Reply-To: <20231018170604.569042-1-jim.cromie@gmail.com>

Add some basic info on classmap usage and api

cc: linux-doc@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v5- adjustments per Randy Dunlap, me
v7b- checkpatch fixes
---
 .../admin-guide/dynamic-debug-howto.rst       | 60 ++++++++++++++++++-
 1 file changed, 59 insertions(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index 0b3d39c610d9..028c2cb5b4c5 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -225,7 +225,6 @@ the ``p`` flag has meaning, other flags are ignored.
 Note the regexp ``^[-+=][fslmpt_]+$`` matches a flags specification.
 To clear all flags at once, use ``=_`` or ``-fslmpt``.
 
-
 Debug messages during Boot Process
 ==================================
 
@@ -375,3 +374,62 @@ just a shortcut for ``print_hex_dump(KERN_DEBUG)``.
 For ``print_hex_dump_debug()``/``print_hex_dump_bytes()``, format string is
 its ``prefix_str`` argument, if it is constant string; or ``hexdump``
 in case ``prefix_str`` is built dynamically.
+
+Dynamic Debug classmaps
+=======================
+
+Dyndbg allows selection/grouping of *prdbg* callsites using structural
+info: module, file, function, line.  Classmaps allow authors to add
+their own domain-oriented groupings using class-names.  Classmaps are
+exported, so they referencable from other modules.
+
+  # enable classes individually
+  :#> ddcmd class DRM_UT_CORE +p
+  :#> ddcmd class DRM_UT_KMS +p
+  # or more selectively
+  :#> ddcmd class DRM_UT_CORE module drm +p
+
+The "class FOO" syntax protects class'd prdbgs from generic overwrite::
+
+  # IOW this doesn't wipe any DRM.debug settings
+  :#> ddcmd -p
+
+To support the DRM.debug parameter, DYNDBG_CLASSMAP_PARAM* updates all
+classes in a classmap, mapping param-bits 0..N onto the classes:
+DRM_UT_<*> for the DRM use-case.
+
+Dynamic Debug Classmap API
+==========================
+
+DYNDBG_CLASSMAP_DEFINE - modules use this to create classmaps, naming
+each of the classes (stringified enum-symbols: "DRM_UT_<*>"), and
+type, and mapping the class-names to consecutive _class_ids.
+
+By doing so, modules tell dyndbg that they are have prdbgs with those
+class_ids, and they authorize dyndbg to accept "class FOO" for the
+module defining that classname.
+
+There are 2 types of classmaps:
+
+ DD_CLASS_TYPE_DISJOINT_BITS: classes are independent, like DRM.debug
+ DD_CLASS_TYPE_LEVEL_NUM: classes are relative, ordered (V3 > V2)
+
+DYNDBG_CLASSMAP_PARAM - refers to a DEFINEd classmap, exposing the set
+of defined classes to manipulation as a group.  This interface
+enforces the relatedness of classes of DD_CLASS_TYPE_LEVEL_NUM typed
+classmaps; all classes are independent in the >control parser itself.
+
+DYNDBG_CLASSMAP_USE - drm drivers invoke this to ref the CLASSMAP that
+drm DEFINEs.  This shares the classmap definition, and authorizes
+dyndbg to apply changes to the user module's class'd pr_debugs.  It
+also tells dyndbg how to initialize the user's prdbgs at modprobe,
+based upon the current setting of the parent's controlling param.
+
+Modules or module-groups (drm & drivers) can define multiple
+classmaps, as long as they share the limited 0..62 per-module-group
+_class_id range, without overlap.
+
+``#define DEBUG`` will enable all pr_debugs in scope, including any
+class'd ones.  This won't be reflected in the PARAM readback value,
+but the pr_debug callsites can be toggled into agreement with the
+param.
-- 
2.41.0


  parent reply	other threads:[~2023-10-18 17:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 17:05 [Intel-gfx] [PATCH v7c 00/24] fix DRM_USE_DYNAMIC_DEBUG=y regression Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 01/24] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 02/24] dyndbg: reword "class unknown, " to "class:_UNKNOWN_" Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 03/24] dyndbg: make ddebug_class_param union members same size Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 04/24] dyndbg: replace classmap list with a vector Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 05/24] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 06/24] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 07/24] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 08/24] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 09/24] dyndbg: silence debugs with no-change updates Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 10/24] dyndbg: tighten ddebug_class_name() 1st arg type Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 11/24] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 12/24] dyndbg: reduce verbose=3 messages in ddebug_add_module Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 13/24] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 14/24] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 15/24] dyndbg: refactor ddebug_classparam_clamp_input Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 16/24] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2023-10-18 17:05 ` Jim Cromie [this message]
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 18/24] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED Jim Cromie
2023-10-18 17:05 ` [Intel-gfx] [PATCH v7c 19/24] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP Jim Cromie
2023-10-18 17:06 ` [Intel-gfx] [PATCH v7c 20/24] dyndbg: refactor *dynamic_emit_prefix Jim Cromie
2023-10-18 17:06 ` [Intel-gfx] [PATCH v7c 21/24] dyndbg: change WARN_ON to WARN_ON_ONCE Jim Cromie
2023-10-18 17:06 ` [Intel-gfx] [PATCH v7c 22/24] drm: use correct ccflags-y spelling Jim Cromie
2023-10-18 17:06 ` [Intel-gfx] [PATCH v7c 23/24] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-10-18 17:06 ` [Intel-gfx] [PATCH v7c 24/24] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2023-10-18 23:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fix DRM_USE_DYNAMIC_DEBUG=y regression (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018170604.569042-18-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bleung@google.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=joe@perches.com \
    --cc=lb@semihalf.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mcgrof@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=seanpaul@chromium.org \
    --cc=yanivt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox