Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
	ville.syrjala@linux.intel.com, imre.deak@intel.com,
	tejas.upadhyay@intel.com, jouni.hogander@intel.com,
	javierm@redhat.com, airlied@gmail.com, daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v6 3/7] drm/i915: Unregister in-kernel clients
Date: Thu,  2 Nov 2023 14:08:08 +0100	[thread overview]
Message-ID: <20231102131056.7256-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20231102131056.7256-1-tzimmermann@suse.de>

Unregister all in-kernel clients before unloading the i915 driver. For
other drivers, drm_dev_unregister() does this automatically. As i915
does not use this helper, it has to perform the call by itself.

Note that there are currently no in-kernel clients in i915. The patch
prepares the driver for a related update of its fbdev support.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/i915/i915_driver.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 80e85cadb9a26..f7b56dcc96a16 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -41,6 +41,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_probe_helper.h>
@@ -857,6 +858,8 @@ void i915_driver_remove(struct drm_i915_private *i915)
 {
 	intel_wakeref_t wakeref;
 
+	drm_client_dev_unregister(&i915->drm);
+
 	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
 
 	i915_driver_unregister(i915);
-- 
2.42.0


  parent reply	other threads:[~2023-11-02 13:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 13:08 [Intel-gfx] [PATCH v6 0/7] drm/i915: Convert fbdev to DRM client Thomas Zimmermann
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 1/7] drm/client: Do not acquire module reference Thomas Zimmermann
2023-11-15 13:07   ` Thomas Zimmermann
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 2/7] drm/client: Export drm_client_dev_unregister() Thomas Zimmermann
2023-11-02 13:08 ` Thomas Zimmermann [this message]
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 4/7] drm/i915: Move fbdev functions Thomas Zimmermann
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 5/7] drm/i915: Initialize fbdev DRM client with callback functions Thomas Zimmermann
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 6/7] drm/i915: Implement fbdev client callbacks Thomas Zimmermann
2023-11-02 13:08 ` [Intel-gfx] [PATCH v6 7/7] drm/i915: Implement fbdev emulation as in-kernel client Thomas Zimmermann
2023-11-02 23:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Convert fbdev to DRM client (rev6) Patchwork
2023-11-02 23:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102131056.7256-4-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jouni.hogander@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tejas.upadhyay@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox