From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v8 3/4] drm/i915/display: Handle invalid fb_modifier in intel_fb_modifier_to_tiling
Date: Thu, 30 Nov 2023 16:43:37 +0200 [thread overview]
Message-ID: <20231130144338.3083821-4-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231130144338.3083821-1-jouni.hogander@intel.com>
Lookup_modifier is returning INTEL_PLANE_CAP_TILING_4 on invalid
fb_modifier value. Use lookup_modifier_or_null in
intel_fb_modifier_to_tiling and return I915_TILING_NONE in case
lookup_modifier_or_null returns null.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 6c89cb2f2002..868e39291e9f 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -303,7 +303,14 @@ lookup_format_info(const struct drm_format_info formats[],
unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)
{
- u8 tiling_caps = lookup_modifier(fb_modifier)->plane_caps &
+ const struct intel_modifier_desc *md;
+ u8 tiling_caps;
+
+ md = lookup_modifier_or_null(fb_modifier);
+ if (!md)
+ return I915_TILING_NONE;
+
+ tiling_caps = lookup_modifier_or_null(fb_modifier)->plane_caps &
INTEL_PLANE_CAP_TILING_MASK;
switch (tiling_caps) {
--
2.34.1
next prev parent reply other threads:[~2023-11-30 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:43 [Intel-gfx] [PATCH v8 0/4] Prepare intel_fb for Xe Jouni Högander
2023-11-30 14:43 ` [Intel-gfx] [PATCH v8 1/4] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c Jouni Högander
2023-11-30 14:43 ` [Intel-gfx] [PATCH v8 2/4] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static Jouni Högander
2023-11-30 14:43 ` Jouni Högander [this message]
2023-11-30 14:43 ` [Intel-gfx] [PATCH v8 4/4] drm/i915/display: Split i915 specific code away from intel_fb.c Jouni Högander
2023-12-01 15:54 ` Ville Syrjälä
2023-12-04 5:31 ` Hogander, Jouni
2023-11-30 21:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe (rev9) Patchwork
2023-11-30 21:28 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-11-30 21:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-12-01 11:00 ` Hogander, Jouni
2023-12-01 11:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-12-02 23:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130144338.3083821-4-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox