Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 6/7] drm/i915/hdcp: Read Rxcaps for robustibility
Date: Fri, 12 Jan 2024 13:11:19 +0530	[thread overview]
Message-ID: <20240112074120.159797-7-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20240112074120.159797-1-suraj.kandpal@intel.com>

We see some monitors and docks report incorrect hdcp version
and capability in first few reads so we read rx_caps three times
before we conclude the monitor's or docks HDCP capability

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 22 ++++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index eff2da976d2c..fce9b4e27f67 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -651,20 +651,24 @@ int intel_dp_hdcp2_capable(struct intel_connector *connector,
 {
 	struct drm_dp_aux *aux;
 	u8 rx_caps[3];
-	int ret;
+	int ret, i;
 
 	aux = intel_dp_hdcp_get_aux(connector, remote_req);
 
 	*capable = false;
-	ret = drm_dp_dpcd_read(aux,
-			       DP_HDCP_2_2_REG_RX_CAPS_OFFSET,
-			       rx_caps, HDCP_2_2_RXCAPS_LEN);
-	if (ret != HDCP_2_2_RXCAPS_LEN)
-		return ret >= 0 ? -EIO : ret;
+	for (i = 0; i < 3; i++) {
+		ret = drm_dp_dpcd_read(aux,
+				       DP_HDCP_2_2_REG_RX_CAPS_OFFSET,
+				       rx_caps, HDCP_2_2_RXCAPS_LEN);
+		if (ret != HDCP_2_2_RXCAPS_LEN)
+			return ret >= 0 ? -EIO : ret;
 
-	if (rx_caps[0] == HDCP_2_2_RX_CAPS_VERSION_VAL &&
-	    HDCP_2_2_DP_HDCP_CAPABLE(rx_caps[2]))
-		*capable = true;
+		if (rx_caps[0] == HDCP_2_2_RX_CAPS_VERSION_VAL &&
+		    HDCP_2_2_DP_HDCP_CAPABLE(rx_caps[2])) {
+			*capable = true;
+			break;
+		}
+	}
 
 	return 0;
 }
-- 
2.25.1


  parent reply	other threads:[~2024-01-12  7:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  7:41 [PATCH 0/7] HDCP Type1 MST fixes Suraj Kandpal
2024-01-12  7:41 ` [PATCH 1/7] drm/i915/hdcp: Move to direct reads for HDCP Suraj Kandpal
2024-01-24 12:49   ` Nautiyal, Ankit K
2024-01-12  7:41 ` [PATCH 2/7] drm/i915/hdcp: HDCP Capability for the downstream device Suraj Kandpal
2024-01-24 13:20   ` Nautiyal, Ankit K
2024-01-25  7:10     ` Nautiyal, Ankit K
2024-01-27  6:44       ` Kandpal, Suraj
2024-01-30  8:45         ` Nautiyal, Ankit K
2024-01-12  7:41 ` [PATCH 3/7] drm/i915/hdcp: Remove additional timing for reading mst hdcp message Suraj Kandpal
2024-01-30  8:53   ` Nautiyal, Ankit K
2024-01-12  7:41 ` [PATCH 4/7] drm/i915/hdcp: Extract hdcp structure from correct connector Suraj Kandpal
2024-01-12  7:41 ` [PATCH 5/7] drm/i915/hdcp: Allocate stream id after HDCP AKE stage Suraj Kandpal
2024-01-12  7:41 ` Suraj Kandpal [this message]
2024-01-12  7:41 ` [PATCH 7/7] drm/i915/display: fastset tbt pll thing Suraj Kandpal
2024-01-12  8:46 ` ✗ Fi.CI.SPARSE: warning for HDCP Type1 MST fixes Patchwork
2024-01-12  8:59 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-12 10:14 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112074120.159797-7-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox