Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/2] drm/i915: Prevent HW access during init from connector hooks
Date: Tue,  6 Feb 2024 17:39:08 +0200	[thread overview]
Message-ID: <20240206153910.1758057-1-imre.deak@intel.com> (raw)

Accessing the display HW from the connector get_modes hooks should be
prevented during driver init/shutdown similarly to how this is done in
the encoder detect hooks and modeset as explained in the following
commits:

drm/i915: Prevent modesets during driver init/shutdown
drm/i915: Disable hotplug detection works during driver init/shutdown
drm/i915: Disable hotplug detection handlers during driver init/shutdown

For the DP-SST/HDMI connectors the above is already ensured, since for
these the required HW access - to read out the display's EDID - happens
in the encoders' detect hook, however other connectors do a
corresponding detection/HW access from the connector get_modes hook.
Disable the access during init/shutdown from these hooks as well.

Imre Deak (2):
  drm/i915: Prevent HW access during init from SDVO TV get_modes hook
  drm/i915: Prevent HW access during init from connector get_modes hooks

 drivers/gpu/drm/i915/display/intel_crt.c    | 7 +++++++
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++++
 drivers/gpu/drm/i915/display/intel_dvo.c    | 5 +++++
 drivers/gpu/drm/i915/display/intel_sdvo.c   | 8 ++++++++
 4 files changed, 24 insertions(+)

-- 
2.39.2


             reply	other threads:[~2024-02-06 15:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 15:39 Imre Deak [this message]
2024-02-06 15:39 ` [PATCH 1/2] drm/i915: Prevent HW access during init from SDVO TV get_modes hook Imre Deak
2024-02-07 13:26   ` Hogander, Jouni
2024-02-07 13:45     ` Hogander, Jouni
2024-02-07 14:10       ` Imre Deak
2024-02-07 15:49         ` Imre Deak
2024-02-07 14:16       ` Imre Deak
2024-02-07 15:35         ` Hogander, Jouni
2024-02-08 11:18   ` [PATCH v2 " Imre Deak
2024-02-06 15:39 ` [PATCH 2/2] drm/i915: Prevent HW access during init from connector get_modes hooks Imre Deak
2024-02-07 15:36   ` Hogander, Jouni
2024-02-06 17:01 ` ✓ Fi.CI.BAT: success for drm/i915: Prevent HW access during init from connector hooks Patchwork
2024-02-06 20:18 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-08 19:26 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Prevent HW access during init from connector hooks (rev2) Patchwork
2024-02-08 19:40 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-08 23:36 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206153910.1758057-1-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox