From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Nirmoy Das <nirmoy.das@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Shawn Lee <shawn.c.lee@intel.com>
Subject: [PATCH] drm/i915: check before removing mm notifier
Date: Mon, 19 Feb 2024 13:50:47 +0100 [thread overview]
Message-ID: <20240219125047.28906-1-nirmoy.das@intel.com> (raw)
Error in mmu_interval_notifier_insert() can leave a NULL
notifier.mm pointer. Catch that and return early.
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Shawn Lee <shawn.c.lee@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index 0e21ce9d3e5a..61abfb505766 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -349,6 +349,9 @@ i915_gem_userptr_release(struct drm_i915_gem_object *obj)
{
GEM_WARN_ON(obj->userptr.page_ref);
+ if (!obj->userptr.notifier.mm)
+ return;
+
mmu_interval_notifier_remove(&obj->userptr.notifier);
obj->userptr.notifier.mm = NULL;
}
--
2.42.0
next reply other threads:[~2024-02-19 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 12:50 Nirmoy Das [this message]
2024-02-19 16:44 ` ✓ Fi.CI.BAT: success for drm/i915: check before removing mm notifier (rev2) Patchwork
2024-02-19 20:12 ` [PATCH] drm/i915: check before removing mm notifier Rodrigo Vivi
2024-02-20 9:05 ` Nirmoy Das
2024-02-19 21:38 ` ✗ Fi.CI.IGT: failure for drm/i915: check before removing mm notifier (rev2) Patchwork
2024-02-20 13:51 ` ✓ Fi.CI.BAT: success for drm/i915: check before removing mm notifier (rev3) Patchwork
2024-02-20 15:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-21 11:52 ` [PATCH] drm/i915: check before removing mm notifier Nirmoy Das
2024-02-27 9:04 ` Tvrtko Ursulin
2024-02-27 9:26 ` Nirmoy Das
2024-02-28 13:24 ` Tvrtko Ursulin
2024-02-28 14:14 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219125047.28906-1-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shawn.c.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox