From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH 1/3] drm/i915/display: Add aux function pointer for fast wake sync pulse count
Date: Wed, 21 Feb 2024 09:53:20 +0200 [thread overview]
Message-ID: <20240221075322.2764209-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240221075322.2764209-1-jouni.hogander@intel.com>
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO
wake and fast wake lines.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++++++
drivers/gpu/drm/i915/display/intel_dp_aux.c | 12 +++++++-----
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 0d4012097db1..1231d374aeec 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1798,6 +1798,12 @@ struct intel_dp {
u32 (*get_aux_send_ctl)(struct intel_dp *dp, int send_bytes,
u32 aux_clock_divider);
+ /*
+ * This function returns the number of fast wake sync pulses. It is
+ * needed by PSR code to calculate needed fast wake and io wake lines.
+ */
+ u8 (*get_aux_fw_sync_len)(void);
+
i915_reg_t (*aux_ch_ctl_reg)(struct intel_dp *dp);
i915_reg_t (*aux_ch_data_reg)(struct intel_dp *dp, int index);
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 4f4a0e3b3114..fad39b2e3022 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -143,10 +143,10 @@ static int intel_dp_aux_sync_len(void)
return precharge + preamble;
}
-static int intel_dp_aux_fw_sync_len(void)
+static u8 intel_dp_aux_fw_sync_len(void)
{
- int precharge = 10; /* 10-16 */
- int preamble = 8;
+ u8 precharge = 10; /* 10-16 */
+ u8 preamble = 8;
return precharge + preamble;
}
@@ -793,10 +793,12 @@ void intel_dp_aux_init(struct intel_dp *intel_dp)
else
intel_dp->get_aux_clock_divider = g4x_get_aux_clock_divider;
- if (DISPLAY_VER(i915) >= 9)
+ if (DISPLAY_VER(i915) >= 9) {
intel_dp->get_aux_send_ctl = skl_get_aux_send_ctl;
- else
+ intel_dp->get_aux_fw_sync_len = intel_dp_aux_fw_sync_len;
+ } else {
intel_dp->get_aux_send_ctl = g4x_get_aux_send_ctl;
+ }
intel_dp->aux.drm_dev = &i915->drm;
drm_dp_aux_init(&intel_dp->aux);
--
2.34.1
next prev parent reply other threads:[~2024-02-21 7:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 7:53 [PATCH 0/3] IO and fast wake lines calculation and increase fw sync length Jouni Högander
2024-02-21 7:53 ` Jouni Högander [this message]
2024-02-21 19:05 ` [PATCH 1/3] drm/i915/display: Add aux function pointer for fast wake sync pulse count Ville Syrjälä
2024-02-21 7:53 ` [PATCH 2/3] drm/i915/psr: Improve fast and IO wake lines calculation Jouni Högander
2024-02-21 19:05 ` Ville Syrjälä
2024-02-21 19:16 ` Ville Syrjälä
2024-02-21 21:45 ` Ville Syrjälä
2024-02-22 9:28 ` Hogander, Jouni
2024-02-22 8:39 ` Hogander, Jouni
2024-02-22 0:42 ` kernel test robot
2024-02-26 10:05 ` Dan Carpenter
2024-02-21 7:53 ` [PATCH 3/3] drm/i915/display: Increase number of fast wake precharge pulses Jouni Högander
2024-02-21 19:11 ` Ville Syrjälä
2024-02-22 9:15 ` Hogander, Jouni
2024-02-21 10:18 ` ✗ Fi.CI.CHECKPATCH: warning for IO and fast wake lines calculation and increase fw sync length Patchwork
2024-02-21 10:18 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-21 10:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-21 12:20 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221075322.2764209-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox