Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Stanislav.Lisovskiy@intel.com, jani.saarinen@intel.com,
	ville.syrjala@linux.intel.com, vidya.srinivas@intel.com
Subject: [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0
Date: Wed, 21 Feb 2024 21:20:10 +0200	[thread overview]
Message-ID: <20240221192010.25413-4-stanislav.lisovskiy@intel.com> (raw)
In-Reply-To: <20240221192010.25413-1-stanislav.lisovskiy@intel.com>

Patch calculates bigjoiner pipes in mst compute.
Patch also passes bigjoiner bool to validate plane
max size.

Signed-off-by: vsrini4 <vidya.srinivas@intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 5307ddd4edcf5..fd27d9976c050 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -523,6 +523,7 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
 				       struct drm_connector_state *conn_state)
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+	struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
 	struct intel_dp_mst_encoder *intel_mst = enc_to_mst(encoder);
 	struct intel_dp *intel_dp = &intel_mst->primary->dp;
 	const struct intel_connector *connector =
@@ -540,6 +541,10 @@ static int intel_dp_mst_compute_config(struct intel_encoder *encoder,
 	if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
 		return -EINVAL;
 
+	if (intel_dp_need_bigjoiner(intel_dp, adjusted_mode->crtc_hdisplay,
+				    adjusted_mode->crtc_clock))
+		pipe_config->bigjoiner_pipes = GENMASK(crtc->pipe + 1, crtc->pipe);
+
 	pipe_config->sink_format = INTEL_OUTPUT_FORMAT_RGB;
 	pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
 	pipe_config->has_pch_encoder = false;
@@ -1318,12 +1323,6 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
 	 *   corresponding link capabilities of the sink) in case the
 	 *   stream is uncompressed for it by the last branch device.
 	 */
-	if (mode_rate > max_rate || mode->clock > max_dotclk ||
-	    drm_dp_calc_pbn_mode(mode->clock, min_bpp << 4) > port->full_pbn) {
-		*status = MODE_CLOCK_HIGH;
-		return 0;
-	}
-
 	if (mode->clock < 10000) {
 		*status = MODE_CLOCK_LOW;
 		return 0;
@@ -1343,6 +1342,12 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
 		return 0;
 	}
 
+	if (mode_rate > max_rate || mode->clock > max_dotclk ||
+	    drm_dp_calc_pbn_mode(mode->clock, min_bpp << 4) > port->full_pbn) {
+		*status = MODE_CLOCK_HIGH;
+		return 0;
+	}
+
 	if (DISPLAY_VER(dev_priv) >= 10 &&
 	    drm_dp_sink_supports_dsc(intel_connector->dp.dsc_dpcd)) {
 		/*
@@ -1385,7 +1390,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
 		return 0;
 	}
 
-	*status = intel_mode_valid_max_plane_size(dev_priv, mode, false);
+	*status = intel_mode_valid_max_plane_size(dev_priv, mode, bigjoiner);
 	return 0;
 }
 
-- 
2.37.3


  parent reply	other threads:[~2024-02-21 19:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 19:20 [PATCH 0/3] Bigjoiner refactoring Stanislav Lisovskiy
2024-02-21 19:20 ` [PATCH 1/3] drm/i915/bigjoiner: Refactor bigjoiner state readout Stanislav Lisovskiy
2024-03-01 10:10   ` Ville Syrjälä
2024-03-01 10:22     ` Lisovskiy, Stanislav
2024-02-21 19:20 ` [PATCH 2/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset Stanislav Lisovskiy
2024-02-27  4:40   ` Srinivas, Vidya
2024-02-27  4:52     ` Srinivas, Vidya
2024-02-27  9:11     ` Lisovskiy, Stanislav
2024-02-27 16:16       ` Srinivas, Vidya
2024-03-01 10:10   ` Ville Syrjälä
2024-03-01 10:27     ` Lisovskiy, Stanislav
2024-03-01 10:43       ` Ville Syrjälä
2024-03-01 12:29         ` Lisovskiy, Stanislav
2024-03-01 14:40           ` Ville Syrjälä
2024-03-01 15:17             ` Lisovskiy, Stanislav
2024-03-01 15:26               ` Ville Syrjälä
2024-03-01 15:42                 ` Lisovskiy, Stanislav
2024-03-01 15:58                   ` Ville Syrjälä
2024-02-21 19:20 ` Stanislav Lisovskiy [this message]
2024-02-21 22:35   ` [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0 Manasi Navare
2024-02-26 19:56   ` Jani Nikula
2024-02-27  9:04     ` Lisovskiy, Stanislav
2024-02-27  9:06       ` Srinivas, Vidya
2024-02-27  9:14         ` Lisovskiy, Stanislav
2024-02-27 18:51           ` Srinivas, Vidya
2024-02-27  9:15       ` Jani Nikula
2024-02-27 18:07         ` Manasi Navare
2024-02-27 18:48           ` Srinivas, Vidya
2024-02-21 23:18 ` ✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev8) Patchwork
2024-02-21 23:18 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-21 23:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-22  6:32 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-02-20 22:09 [PATCH 0/3] Bigjoiner refactoring Stanislav Lisovskiy
2024-02-20 22:09 ` [PATCH 3/3] drm/i915: Fix bigjoiner case for DP2.0 Stanislav Lisovskiy
2024-02-21  3:33   ` Almahallawy, Khaled

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221192010.25413-4-stanislav.lisovskiy@intel.com \
    --to=stanislav.lisovskiy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=vidya.srinivas@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox