From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
tiwai@suse.com, perex@perex.cz, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org,
amadeuszx.slawinski@linux.intel.com,
pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v3 2/5] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing
Date: Mon, 26 Feb 2024 13:44:29 +0100 [thread overview]
Message-ID: <20240226124432.1203798-3-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20240226124432.1203798-1-cezary.rojewski@intel.com>
If i915 does not support given platform but the hardware i.e.: HDAudio
codec is still there, the codec-probing procedure will succeed for such
device but the follow up initialization will always end up with -ENODEV.
While bus could filter out address '2' which Intel's HDMI/DP codecs
always enumerate on, more robust approach is to check for i915 presence
before registering display codecs.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/codecs/hda.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/soc/codecs/hda.c b/sound/soc/codecs/hda.c
index d2117e36ddd1..7c6bedeceaa2 100644
--- a/sound/soc/codecs/hda.c
+++ b/sound/soc/codecs/hda.c
@@ -350,6 +350,11 @@ static int hda_hdev_attach(struct hdac_device *hdev)
struct hda_codec *codec = dev_to_hda_codec(&hdev->dev);
struct snd_soc_component_driver *comp_drv;
+ if (hda_codec_is_display(codec) && !hdev->bus->audio_component) {
+ dev_dbg(&hdev->dev, "no i915, skip registration for 0x%08x\n", hdev->vendor_id);
+ return -ENODEV;
+ }
+
comp_drv = devm_kzalloc(&hdev->dev, sizeof(*comp_drv), GFP_KERNEL);
if (!comp_drv)
return -ENOMEM;
--
2.25.1
next prev parent reply other threads:[~2024-02-26 12:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 12:44 [PATCH v3 0/5] ALSA/ASoC: Conditionally skip i915 init and cleanups Cezary Rojewski
2024-02-26 12:44 ` [PATCH v3 1/5] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms Cezary Rojewski
2024-02-26 12:44 ` Cezary Rojewski [this message]
2024-02-28 17:21 ` [PATCH v3 2/5] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing Mark Brown
2024-02-26 12:44 ` [PATCH v3 3/5] ASoC: Intel: avs: Ignore codecs with no suppoting driver Cezary Rojewski
2024-02-28 17:22 ` Mark Brown
2024-02-26 12:44 ` [PATCH v3 4/5] ASoC: codecs: hda: Cleanup error messages Cezary Rojewski
2024-02-28 17:22 ` Mark Brown
2024-02-26 12:44 ` [PATCH v3 5/5] ALSA: hda: Reuse for_each_pcm_streams() Cezary Rojewski
2024-02-26 20:09 ` ✓ Fi.CI.BAT: success for ALSA/ASoC: Conditionally skip i915 init and cleanups (rev3) Patchwork
2024-02-27 2:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-04 8:18 ` [PATCH v3 0/5] ALSA/ASoC: Conditionally skip i915 init and cleanups Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226124432.1203798-3-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tiwai@suse.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox