From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
"Simon Ser" <contact@emersion.fr>,
"Jonas Ådahl" <jadahl@redhat.com>,
"Daniel Stone" <daniel@fooishbar.org>,
"Sameer Lattannavar" <sameer.lattannavar@intel.com>,
"Sebastian Wick" <sebastian.wick@redhat.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>
Subject: [PATCH v2 0/2] drm: Add plane SIZE_HINTS property
Date: Tue, 27 Feb 2024 21:35:21 +0200 [thread overview]
Message-ID: <20240227193523.5601-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Final version for a new plane SIZE_HINTS property to
essentially replace the cursor size caps, based on recent
discussion in this gitlab bug:
https://gitlab.freedesktop.org/drm/intel/-/issues/7687
As for userspace, so far I only did a quick modetest
blob decoder (mainly to verify that it looks correct):
https://gitlab.freedesktop.org/vsyrjala/libdrm/-/commits/plane_size_hints
Sameer & co. have done a real mutter implementation:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3165
This final version follows the original idea of having
just a list of sizes in a blob, rather than the mode
complex "2D bitmap" approach I also proposed later.
I think that's fair, the bitmap was probably overly
complicated.
The only difference to the previous version of this approach
is that the documentation now states that the list is sorted
in order of preference, and thus userspace should pick the
first suitable size from the list. This should match the
aforementioned mutter implementation.
Cc: Simon Ser <contact@emersion.fr>
Cc: Jonas Ådahl <jadahl@redhat.com>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Sameer Lattannavar <sameer.lattannavar@intel.com>
Cc: Sebastian Wick <sebastian.wick@redhat.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
Ville Syrjälä (2):
drm: Introduce plane SIZE_HINTS property
drm/i915: Add SIZE_HINTS property for cursors
drivers/gpu/drm/drm_mode_config.c | 7 +++
drivers/gpu/drm/drm_plane.c | 52 +++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_cursor.c | 24 ++++++++++
include/drm/drm_mode_config.h | 5 ++
include/drm/drm_plane.h | 4 ++
include/uapi/drm/drm_mode.h | 11 +++++
6 files changed, 103 insertions(+)
--
2.43.0
next reply other threads:[~2024-02-27 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 19:35 Ville Syrjala [this message]
2024-02-27 19:35 ` [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property Ville Syrjala
2024-02-27 20:32 ` Sebastian Wick
2024-02-28 10:12 ` Simon Ser
2024-03-15 17:03 ` Ville Syrjälä
2024-02-28 10:28 ` Daniel Stone
2024-02-27 19:35 ` [PATCH v2 2/2] drm/i915: Add SIZE_HINTS property for cursors Ville Syrjala
2024-02-27 20:12 ` ✗ Fi.CI.SPARSE: warning for drm: Add plane SIZE_HINTS property (rev5) Patchwork
2024-02-27 20:24 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-28 12:01 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227193523.5601-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=contact@emersion.fr \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jadahl@redhat.com \
--cc=pekka.paalanen@collabora.com \
--cc=sameer.lattannavar@intel.com \
--cc=sebastian.wick@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox