Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/3] drm/i915: Disable planes more atomically during modesets
Date: Tue,  5 Mar 2024 10:47:29 +0200	[thread overview]
Message-ID: <20240305084730.19182-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240305084730.19182-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Follow in the footsteps of commit c610e841f19d ("drm/i915:
Do plane/etc. updates more atomically across pipes") and
do the plane disables back to back for all pipes also when
we are disabling pipes.

This should provide for a potentially more atomic user
experience, which might be especially nice when using
joiner or tiled displays.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d1c947a310a3..d1902976084e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6788,11 +6788,16 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state)
 		if (!old_crtc_state->hw.active)
 			continue;
 
-		intel_crtc_disable_planes(state, crtc);
-
 		disable_pipes |= BIT(crtc->pipe);
 	}
 
+	for_each_old_intel_crtc_in_state(state, crtc, old_crtc_state, i) {
+		if ((disable_pipes & BIT(crtc->pipe)) == 0)
+			continue;
+
+		intel_crtc_disable_planes(state, crtc);
+	}
+
 	/* Only disable port sync and MST slaves */
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
 					    new_crtc_state, i) {
-- 
2.43.0


  parent reply	other threads:[~2024-03-05  8:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  8:47 [PATCH 0/3] drm/i915: Make crtc disable more atomic Ville Syrjala
2024-03-05  8:47 ` [PATCH 1/3] drm/i915: Precompute disable_pipes bitmask in intel_commit_modeset_disables() Ville Syrjala
2024-03-05  8:47 ` Ville Syrjala [this message]
2024-03-05  8:47 ` [PATCH 3/3] drm/i915: Simplify intel_old_crtc_state_disables() calling convention Ville Syrjala
2024-03-05 20:08 ` ✗ Fi.CI.BAT: failure for drm/i915: Make crtc disable more atomic Patchwork
2024-03-06 11:51 ` ✗ Fi.CI.BAT: failure for drm/i915: Make crtc disable more atomic (rev2) Patchwork
2024-03-07  3:26 ` ✓ Fi.CI.BAT: success for drm/i915: Make crtc disable more atomic (rev3) Patchwork
2024-03-07 17:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-08  6:58 ` [PATCH 0/3] drm/i915: Make crtc disable more atomic Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305084730.19182-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox