Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v6 4/4] drm/i915/display: Increase number of fast wake precharge pulses
Date: Wed, 13 Mar 2024 15:32:21 +0200	[thread overview]
Message-ID: <20240313133221.868391-5-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240313133221.868391-1-jouni.hogander@intel.com>

Increasing number of fast wake sync pulses seem to fix problems with
certain PSR panels. This should be ok for other panels as well as the eDP
specification allows 10...16 precharge pulses and we are still within that
range.

v2: add comment explaining pulse count is increased

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9739
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 7e69be100d90..3264026454b2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -145,7 +145,12 @@ static int intel_dp_aux_sync_len(void)
 
 int intel_dp_aux_fw_sync_len(void)
 {
-	int precharge = 10; /* 10-16 */
+	/*
+	 * We faced some glitches on MTL with one PSR2 panel when using HW
+	 * default 18. Using 20 is fixing these problems with the panel. It is
+	 * still within range mentioned in eDP specification.
+	 */
+	int precharge = 12; /* 10-16 */
 	int preamble = 8;
 
 	return precharge + preamble;
-- 
2.34.1


  parent reply	other threads:[~2024-03-13 13:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 13:32 [PATCH v6 0/4] IO and fast wake lines calculation and increase fw sync length Jouni Högander
2024-03-13 13:32 ` [PATCH v6 1/4] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code Jouni Högander
2024-03-13 13:32 ` [PATCH v6 2/4] drm/i915/psr: Improve fast and IO wake lines calculation Jouni Högander
2024-03-13 13:32 ` [PATCH v6 3/4] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12 Jouni Högander
2024-03-13 13:32 ` Jouni Högander [this message]
2024-03-13 14:01   ` [PATCH v6 4/4] drm/i915/display: Increase number of fast wake precharge pulses Ville Syrjälä
2024-03-14 14:38     ` Hogander, Jouni
2024-03-14  0:38 ` ✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev6) Patchwork
2024-03-14  0:51 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-14 10:01 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-14 11:53   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313133221.868391-5-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox