From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.saarinen@intel.com, Stanislav.Lisovskiy@intel.com,
ville.syrjala@linux.intel.com
Subject: [PATCH 3/5] drm/i915: Use old mbus_join value when increasing CDCLK
Date: Fri, 22 Mar 2024 13:40:44 +0200 [thread overview]
Message-ID: <20240322114046.24930-4-stanislav.lisovskiy@intel.com> (raw)
In-Reply-To: <20240322114046.24930-1-stanislav.lisovskiy@intel.com>
In order to make sure we are not breaking the proper sequence
lets to updates step by step and don't change MBUS join value
during MDCLK/CDCLK programming stage.
MBUS join programming would be taken care by pre/post ddb hooks.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 31aaa9780dfcf..43a9616c78260 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -2611,9 +2611,19 @@ intel_set_cdclk_pre_plane_update(struct intel_atomic_state *state)
if (pipe == INVALID_PIPE ||
old_cdclk_state->actual.cdclk <= new_cdclk_state->actual.cdclk) {
+ struct intel_cdclk_config cdclk_config;
+
drm_WARN_ON(&i915->drm, !new_cdclk_state->base.changed);
- intel_set_cdclk(i915, &new_cdclk_state->actual, pipe);
+ /*
+ * By this hack we want to prevent mbus_join to be programmed
+ * beforehand - we will take care of this later in pre ddb
+ * programming hook.
+ */
+ cdclk_config = new_cdclk_state->actual;
+ cdclk_config.joined_mbus = old_cdclk_state->actual.joined_mbus;
+
+ intel_set_cdclk(i915, &cdclk_config, pipe);
}
}
--
2.37.3
next prev parent reply other threads:[~2024-03-22 11:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 11:40 [PATCH 0/5] Enable fastset for mbus_join state change Stanislav Lisovskiy
2024-03-22 11:40 ` [PATCH 1/5] drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly Stanislav Lisovskiy
2024-03-22 17:46 ` Ville Syrjälä
2024-03-22 11:40 ` [PATCH 2/5] drm/i915: Break intel_dbuf_mbus_update into 2 separate parts Stanislav Lisovskiy
2024-03-22 17:50 ` Ville Syrjälä
2024-03-22 11:40 ` Stanislav Lisovskiy [this message]
2024-03-22 17:45 ` [PATCH 3/5] drm/i915: Use old mbus_join value when increasing CDCLK Ville Syrjälä
2024-03-25 14:44 ` Gustavo Sousa
2024-03-25 14:55 ` Ville Syrjälä
2024-03-22 11:40 ` [PATCH 4/5] drm/i915: Loop over all active pipes in intel_mbus_dbox_update Stanislav Lisovskiy
2024-03-22 17:51 ` Ville Syrjälä
2024-03-22 11:40 ` [PATCH 5/5] drm/i915: Implement vblank synchronized MBUS join changes Stanislav Lisovskiy
2024-03-22 18:06 ` Ville Syrjälä
2024-03-25 8:59 ` Lisovskiy, Stanislav
2024-03-25 9:09 ` [PATCH 3/3] " Stanislav Lisovskiy
2024-03-22 12:28 ` ✗ Fi.CI.CHECKPATCH: warning for Enable fastset for mbus_join state change (rev2) Patchwork
2024-03-22 12:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-23 8:31 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322114046.24930-4-stanislav.lisovskiy@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox