From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com, uma.shankar@intel.com,
ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com,
Suraj Kandpal <suraj.kandpal@intel.com>,
Sebastian Wick <sebastian.wick@redhat.com>
Subject: [PATCH 7/7] drm/i915/dp: Write panel override luminance values
Date: Tue, 7 May 2024 09:34:07 +0530 [thread overview]
Message-ID: <20240507040407.1056061-8-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20240507040407.1056061-1-suraj.kandpal@intel.com>
Write panel override luminance values which helps the TCON decide
if tone mapping needs to be enabled or not.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Sebastian Wick <sebastian.wick@redhat.com>
---
.../drm/i915/display/intel_dp_aux_backlight.c | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index da42f6704930..8ce60d53dcde 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -374,6 +374,29 @@ static const char *dpcd_vs_pwm_str(bool aux)
return aux ? "DPCD" : "PWM";
}
+static void
+intel_dp_aux_write_panel_luminance_override(struct intel_connector *connector)
+{
+ struct drm_i915_private *i915 = to_i915(connector->base.dev);
+ struct intel_panel *panel = &connector->panel;
+ struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
+ int ret;
+ u8 buf[4] = {};
+
+ buf[0] = panel->backlight.min & 0xFF;
+ buf[1] = (panel->backlight.min & 0xFF00) >> 8;
+ buf[2] = panel->backlight.max & 0xFF;
+ buf[3] = (panel->backlight.max & 0xFF00) >> 8;
+
+ ret = drm_dp_dpcd_write(&intel_dp->aux,
+ INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE,
+ buf, sizeof(buf));
+ if (ret < 0)
+ drm_dbg_kms(&i915->drm,
+ "Panel Luminance DPCD reg write failed, err:-%d\n",
+ ret);
+}
+
static int
intel_dp_aux_hdr_setup_backlight(struct intel_connector *connector, enum pipe pipe)
{
@@ -405,6 +428,8 @@ intel_dp_aux_hdr_setup_backlight(struct intel_connector *connector, enum pipe pi
panel->backlight.min = 0;
}
+ intel_dp_aux_write_panel_luminance_override(connector);
+
drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] Using AUX HDR interface for backlight control (range %d..%d)\n",
connector->base.base.id, connector->base.name,
panel->backlight.min, panel->backlight.max);
--
2.43.2
next prev parent reply other threads:[~2024-05-07 4:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 4:04 [PATCH 0/7] Enable Aux Based EDP HDR Suraj Kandpal
2024-05-07 4:04 ` [PATCH 1/7] drm/i915/dp: Make has_gamut_metadata_dip() non static Suraj Kandpal
2024-05-07 4:04 ` [PATCH 2/7] drm/i915/dp: Rename intel struct inside intel_panel Suraj Kandpal
2024-05-07 4:04 ` [PATCH 3/7] drm/i915/dp: Add TCON HDR capability checks Suraj Kandpal
2024-05-07 4:04 ` [PATCH 4/7] drm/i915/dp: Fix Register bit naming Suraj Kandpal
2024-05-07 4:04 ` [PATCH 5/7] drm/i915/dp: Drop comments on EDP HDR DPCD registers Suraj Kandpal
2024-05-07 4:04 ` [PATCH 6/7] drm/i915/dp: Enable AUX based backlight for HDR Suraj Kandpal
2024-05-07 4:04 ` Suraj Kandpal [this message]
2024-05-07 4:50 ` ✗ Fi.CI.SPARSE: warning for Enable Aux Based EDP HDR (rev5) Patchwork
2024-05-07 4:54 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-07 10:28 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-09 9:19 ` ✓ Fi.CI.IGT: success " Patchwork
2024-05-13 10:29 ` [PATCH 0/7] Enable Aux Based EDP HDR Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507040407.1056061-8-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sebastian.wick@redhat.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox