From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 1/9] drm/i915/psr: Do not use fast_wake_lines for aux less wake time
Date: Tue, 21 May 2024 11:41:15 +0300 [thread overview]
Message-ID: <20240521084123.1984075-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240521084123.1984075-1-jouni.hogander@intel.com>
We want to have own variables for fast wake lines and aux less wake
time. It might be needed to choose if we can enable Panel Replay Selective
Update or PSR2.
Also currently aux less wake time is overwritten by calculated fast wake
time.
Fixes: da6a9836ac09 ("drm/i915/psr: Calculate aux less wake time")
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 9678c2b157f6..95a806538cdc 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1712,6 +1712,7 @@ struct intel_psr {
/* LNL and beyond */
u8 check_entry_lines;
+ u8 aux_less_wake_lines;
u8 silence_period_sym_clocks;
u8 lfps_half_cycle_num_of_syms;
} alpm_parameters;
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index d18baeb971bb..1fadac7d9d94 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1348,7 +1348,7 @@ static int _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp,
if (i915->display.params.psr_safest_params)
aux_less_wake_lines = ALPM_CTL_AUX_LESS_WAKE_TIME_MASK;
- intel_dp->psr.alpm_parameters.fast_wake_lines = aux_less_wake_lines;
+ intel_dp->psr.alpm_parameters.aux_less_wake_lines = aux_less_wake_lines;
intel_dp->psr.alpm_parameters.silence_period_sym_clocks = silence_period;
intel_dp->psr.alpm_parameters.lfps_half_cycle_num_of_syms = lfps_half_cycle;
--
2.34.1
next prev parent reply other threads:[~2024-05-21 8:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 8:41 [PATCH v2 0/9] Panel Replay Fixes Jouni Högander
2024-05-21 8:41 ` Jouni Högander [this message]
2024-05-21 8:41 ` [PATCH v2 2/9] drm/i915/psr: Add Early Transport status boolean into intel_psr Jouni Högander
2024-05-21 8:41 ` [PATCH v2 3/9] drm/i915/psr: Get Early Transport status in intel_psr_pipe_get_config Jouni Högander
2024-05-21 8:41 ` [PATCH v2 4/9] drm/i915/psr: Use enable boolean from intel_crtc_state for Early Transport Jouni Högander
2024-05-21 8:41 ` [PATCH v2 5/9] drm/i915/psr: Allow setting I915_PSR_DEBUG_SU_REGION_ET_DISABLE via debugfs Jouni Högander
2024-05-21 8:41 ` [PATCH v2 6/9] drm/i915/display: Take panel replay into account in vsc sdp unpacking Jouni Högander
2024-05-21 8:41 ` [PATCH v2 7/9] drm/i915/display: Skip Panel Replay on pipe comparison if no active planes Jouni Högander
2024-05-21 8:41 ` [PATCH v2 8/9] drm/i915/psr: Write also AUX Less Wake lines into ALPM_CTL Jouni Högander
2024-05-21 8:41 ` [PATCH v2 9/9] drm/i915/display: Selective fetch Y position on Region Early Transport Jouni Högander
2024-05-21 9:37 ` ✗ Fi.CI.SPARSE: warning for Panel Replay Fixes (rev2) Patchwork
2024-05-21 9:51 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-22 4:14 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521084123.1984075-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox