Re: [PATCH 4/5] drm/i915: Compute config and mode valid changes for ultrajoiner

[kernel test robot <lkp@intel.com>]

Hi Stanislav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master next-20240520]
[cannot apply to drm-intel/for-linux-next-fixes v6.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Lisovskiy/drm-i915-Rename-all-bigjoiner-to-joiner/20240520-194208
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240520073839.23881-5-stanislav.lisovskiy%40intel.com
patch subject: [PATCH 4/5] drm/i915: Compute config and mode valid changes for ultrajoiner
config: x86_64-randconfig-103-20240521 (https://download.01.org/0day-ci/archive/20240521/202405211228.a5iQwc2H-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405211228.a5iQwc2H-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/display/intel_vdsc.c:813:46-47: Unneeded semicolon

vim +813 drivers/gpu/drm/i915/display/intel_vdsc.c

   783	
   784	void intel_dsc_enable(const struct intel_crtc_state *crtc_state)
   785	{
   786		struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
   787		struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
   788		u32 dss_ctl1_val = 0;
   789		u32 dss_ctl2_val = 0;
   790		int vdsc_instances_per_pipe = intel_dsc_get_vdsc_per_pipe(crtc_state);
   791	
   792		if (!crtc_state->dsc.compression_enable)
   793			return;
   794	
   795		intel_dsc_pps_configure(crtc_state);
   796	
   797		dss_ctl2_val |= LEFT_BRANCH_VDSC_ENABLE;
   798		if (vdsc_instances_per_pipe > 1) {
   799			dss_ctl2_val |= RIGHT_BRANCH_VDSC_ENABLE;
   800			dss_ctl1_val |= JOINER_ENABLE;
   801		}
   802	
   803		if (crtc_state->joiner_pipes) {
   804			/*
   805			 * This bit doesn't seem to follow master/slave logic or
   806			 * any other logic, so lets just add helper function to
   807			 * at least hide this hassle..
   808			 */
   809			if (intel_crtc_ultrajoiner_enable_needed(crtc_state))
   810				dss_ctl1_val |= ULTRA_JOINER_ENABLE;
   811	
   812			if (intel_crtc_is_joiner_primary_master(crtc_state))
 > 813				dss_ctl1_val |= MASTER_ULTRA_JOINER_ENABLE;;
   814	
   815			dss_ctl1_val |= BIG_JOINER_ENABLE;
   816	
   817			if (intel_crtc_is_bigjoiner_master(crtc_state))
   818				dss_ctl1_val |= MASTER_BIG_JOINER_ENABLE;
   819		}
   820		intel_de_write(dev_priv, dss_ctl1_reg(crtc, crtc_state->cpu_transcoder), dss_ctl1_val);
   821		intel_de_write(dev_priv, dss_ctl2_reg(crtc, crtc_state->cpu_transcoder), dss_ctl2_val);
   822	}
   823	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki