Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 05/19] drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid
Date: Fri, 31 May 2024 12:49:39 +0300	[thread overview]
Message-ID: <20240531094953.1797508-6-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240531094953.1797508-1-jouni.hogander@intel.com>

Early Transport is possible and in our HW mandatory on eDP Panel
Replay. Add parameter to intel_psr2_config_et_valid to differentiate
validity check for Panel Replay.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 4b337bcd9c90..05aff2adb19e 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -674,16 +674,17 @@ static void hsw_psr_setup_aux(struct intel_dp *intel_dp)
 		       aux_ctl);
 }
 
-static bool psr2_su_region_et_valid(struct intel_dp *intel_dp)
+static bool psr2_su_region_et_valid(struct intel_dp *intel_dp, bool panel_replay)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 
-	if (DISPLAY_VER(i915) >= 20 &&
-	    intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_ET_SUPPORTED &&
-	    !(intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE))
-		return true;
+	if (DISPLAY_VER(i915) < 20 || !intel_dp_is_edp(intel_dp) ||
+	    intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE)
+		return false;
 
-	return false;
+	return panel_replay ?
+		intel_dp->pr_dpcd & DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT :
+		intel_dp->psr_dpcd[0] != DP_PSR2_WITH_Y_COORD_ET_SUPPORTED;
 }
 
 static unsigned int intel_psr_get_enable_sink_offset(struct intel_dp *intel_dp)
@@ -710,7 +711,7 @@ void intel_psr_enable_sink(struct intel_dp *intel_dp,
 					   DP_ALPM_ENABLE |
 					   DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE);
 
-			if (psr2_su_region_et_valid(intel_dp))
+			if (psr2_su_region_et_valid(intel_dp, crtc_state->has_panel_replay))
 				dpcd_val |= DP_PSR_ENABLE_SU_REGION_ET;
 		}
 
@@ -978,7 +979,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
 			       PSR2_MAN_TRK_CTL(dev_priv, cpu_transcoder), 0);
 	}
 
-	if (psr2_su_region_et_valid(intel_dp))
+	if (psr2_su_region_et_valid(intel_dp, false))
 		val |= LNL_EDP_PSR2_SU_REGION_ET_ENABLE;
 
 	/*
@@ -1355,7 +1356,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
 
 	tgl_dc3co_exitline_compute_config(intel_dp, crtc_state);
 
-	if (psr2_su_region_et_valid(intel_dp))
+	if (psr2_su_region_et_valid(intel_dp, crtc_state->has_panel_replay))
 		crtc_state->enable_psr2_su_region_et = true;
 
 	return true;
-- 
2.34.1


  parent reply	other threads:[~2024-05-31  9:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  9:49 [PATCH v4 00/19] Panel Replay eDP support Jouni Högander
2024-05-31  9:49 ` [PATCH v4 01/19] drm/i915/alpm: Do not use fast_wake_lines for aux less wake time Jouni Högander
2024-05-31  9:49 ` [PATCH v4 02/19] drm/i915/alpm: Write also AUX Less Wake lines into ALPM_CTL Jouni Högander
2024-05-31  9:49 ` [PATCH v4 03/19] drm/i915/display: Take panel replay into account in vsc sdp unpacking Jouni Högander
2024-05-31  9:49 ` [PATCH v4 04/19] drm/i915/display: Skip Panel Replay on pipe comparison if no active planes Jouni Högander
2024-05-31  9:49 ` Jouni Högander [this message]
2024-05-31  9:49 ` [PATCH v4 06/19] drm/i915/alpm: Make alpm support checks non-static Jouni Högander
2024-05-31  9:49 ` [PATCH v4 07/19] drm/i915/psr: Check panel ALPM capability for eDP Panel Replay Jouni Högander
2024-05-31  9:49 ` [PATCH v4 08/19] drm/i915/psr: Use intel_alpm_aux_wake_supported instead of local variable Jouni Högander
2024-05-31  9:49 ` [PATCH v4 09/19] drm/i915/psr: Inform Panel Replay source support on eDP as well Jouni Högander
2024-05-31  9:49 ` [PATCH v4 10/19] drm/i915/psr: enable sink for eDP1.5 Panel Replay Jouni Högander
2024-05-31  9:49 ` [PATCH v4 11/19] drm/i915/psr: Check panel Early Transport capability for eDP PR Jouni Högander
2024-05-31  9:49 ` [PATCH v4 12/19] drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay Jouni Högander
2024-05-31  9:49 ` [PATCH v4 13/19] drm/i915/psr: Add Panel Replay compute_config helper Jouni Högander
2024-05-31  9:49 ` [PATCH v4 14/19] drm/i915/psr: 128b/132b Panel Replay is not supported on eDP Jouni Högander
2024-05-31  9:49 ` [PATCH v4 15/19] drm/i915/psr: HW will not allow PR on eDP when HDCP enabled Jouni Högander
2024-05-31  9:49 ` [PATCH v4 16/19] drm/i915/psr: Check Early Transport for Panel Replay as well Jouni Högander
2024-05-31  9:49 ` [PATCH v4 17/19] drm/i915/psr: Modify dg2_activate_panel_replay to support eDP Jouni Högander
2024-05-31  9:49 ` [PATCH v4 18/19] drm/i915/psr: Add new debug bit to disable Panel Replay Jouni Högander
2024-05-31  9:49 ` [PATCH v4 19/19] Revert "drm/i915/psr: Disable early transport by default" Jouni Högander
2024-05-31 10:17 ` ✗ Fi.CI.SPARSE: warning for Panel Replay eDP support (rev5) Patchwork
2024-05-31 10:18 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-01  9:29 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531094953.1797508-6-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox