From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v5 01/19] drm/i915/alpm: Do not use fast_wake_lines for aux less wake time
Date: Mon, 3 Jun 2024 16:00:25 +0300 [thread overview]
Message-ID: <20240603130043.2615716-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240603130043.2615716-1-jouni.hogander@intel.com>
We want to have own variables for fast wake lines and aux less wake
time. It might be needed to choose if we can enable Panel Replay Selective
Update or PSR2.
Also currently aux less wake time is overwritten by calculated fast wake
time.
Fixes: da6a9836ac09 ("drm/i915/psr: Calculate aux less wake time")
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 2 +-
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index a26716c14aa3..aa15f57cec66 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -159,7 +159,7 @@ static int _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp,
if (i915->display.params.psr_safest_params)
aux_less_wake_lines = ALPM_CTL_AUX_LESS_WAKE_TIME_MASK;
- intel_dp->alpm_parameters.fast_wake_lines = aux_less_wake_lines;
+ intel_dp->alpm_parameters.aux_less_wake_lines = aux_less_wake_lines;
intel_dp->alpm_parameters.silence_period_sym_clocks = silence_period;
intel_dp->alpm_parameters.lfps_half_cycle_num_of_syms = lfps_half_cycle;
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 77609656317b..df29ec37ef28 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1847,6 +1847,7 @@ struct intel_dp {
/* LNL and beyond */
u8 check_entry_lines;
+ u8 aux_less_wake_lines;
u8 silence_period_sym_clocks;
u8 lfps_half_cycle_num_of_syms;
} alpm_parameters;
--
2.34.1
next prev parent reply other threads:[~2024-06-03 13:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 13:00 [PATCH v5 00/19] Panel Replay eDP support Jouni Högander
2024-06-03 13:00 ` Jouni Högander [this message]
2024-06-03 13:00 ` [PATCH v5 02/19] drm/i915/alpm: Write also AUX Less Wake lines into ALPM_CTL Jouni Högander
2024-06-03 13:00 ` [PATCH v5 03/19] drm/i915/display: Take panel replay into account in vsc sdp unpacking Jouni Högander
2024-06-03 13:00 ` [PATCH v5 04/19] drm/i915/display: Skip Panel Replay on pipe comparison if no active planes Jouni Högander
2024-06-03 13:00 ` [PATCH v5 05/19] drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid Jouni Högander
2024-06-03 13:00 ` [PATCH v5 06/19] drm/i915/alpm: Make alpm support checks non-static Jouni Högander
2024-06-03 13:00 ` [PATCH v5 07/19] drm/i915/psr: Check panel ALPM capability for eDP Panel Replay Jouni Högander
2024-06-03 13:00 ` [PATCH v5 08/19] drm/i915/psr: Use intel_alpm_aux_wake_supported instead of local variable Jouni Högander
2024-06-03 13:00 ` [PATCH v5 09/19] drm/i915/psr: Inform Panel Replay source support on eDP as well Jouni Högander
2024-06-03 13:00 ` [PATCH v5 10/19] drm/i915/psr: enable sink for eDP1.5 Panel Replay Jouni Högander
2024-06-03 13:00 ` [PATCH v5 11/19] drm/i915/psr: Check panel Early Transport capability for eDP PR Jouni Högander
2024-06-03 13:00 ` [PATCH v5 12/19] drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay Jouni Högander
2024-06-03 13:00 ` [PATCH v5 13/19] drm/i915/psr: Add Panel Replay compute_config helper Jouni Högander
2024-06-03 13:00 ` [PATCH v5 14/19] drm/i915/psr: 128b/132b Panel Replay is not supported on eDP Jouni Högander
2024-06-03 13:00 ` [PATCH v5 15/19] drm/i915/psr: HW will not allow PR on eDP when HDCP enabled Jouni Högander
2024-06-03 13:00 ` [PATCH v5 16/19] drm/i915/psr: Check Early Transport for Panel Replay as well Jouni Högander
2024-06-03 13:00 ` [PATCH v5 17/19] drm/i915/psr: Modify dg2_activate_panel_replay to support eDP Jouni Högander
2024-06-03 13:00 ` [PATCH v5 18/19] drm/i915/psr: Add new debug bit to disable Panel Replay Jouni Högander
2024-06-03 13:00 ` [PATCH v5 19/19] Revert "drm/i915/psr: Disable early transport by default" Jouni Högander
2024-06-03 13:45 ` ✗ Fi.CI.SPARSE: warning for Panel Replay eDP support (rev6) Patchwork
2024-06-03 13:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-03 23:38 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603130043.2615716-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox