public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Melanie Lobo <melanie.lobo@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com, swati2.sharma@intel.com,
	bhanuprakash.modem@intel.com, vidya.srinivas@intel.com,
	Melanie Lobo <melanie.lobo@intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Subject: [PATCH] drm/i915: Support RGB16161616_64B compressed formats
Date: Wed,  5 Jun 2024 11:34:57 +0530	[thread overview]
Message-ID: <20240605060457.10086-1-melanie.lobo@intel.com> (raw)
In-Reply-To: <20231011102356.22014-1-melanie.lobo@intel.com>

Add support for a RGB64(FP16) format where each color component is a
16-bit floating point value. FP16 format which is a binary
floating-point computer number format that occupies 16 bits in computer
memory. Platform shall render compression in display engine to receive
FP16 compressed formats.

This kernel change was tested with IGT patch,
https://patchwork.freedesktop.org/series/134353/
https://lore.kernel.org/all/20240603081607.30930-1-melanie.lobo@intel.com/

Test-with: 20240603081607.30930-1-melanie.lobo@intel.com

Credits: Juha-Pekka <juha-pekka.heikkila@intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fb.c            | 5 +++++
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index b6638726949d..91f2def14243 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -91,6 +91,11 @@ static const struct drm_format_info gen12_ccs_formats[] = {
 	{ .format = DRM_FORMAT_P016, .num_planes = 4,
 	  .char_per_block = { 2, 4, 1, 1 }, .block_w = { 1, 1, 2, 2 }, .block_h = { 1, 1, 1, 1 },
 	  .hsub = 2, .vsub = 2, .is_yuv = true },
+	{ .format = DRM_FORMAT_XRGB16161616F, .depth = 64, .num_planes = 2,
+	  .char_per_block = { 8, 1}, .block_w = { 1, 4}, .block_h = { 1, 2}, .hsub = 1, .vsub = 1},
+	{ .format = DRM_FORMAT_ARGB16161616F, .depth = 64, .num_planes = 2,
+	  .char_per_block = { 8, 1}, .block_w = { 1, 4}, .block_h = { 1, 2},
+	  .hsub = 1, .vsub = 1, .has_alpha = true},
 };
 
 /*
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 1aa70fc35b9d..7719cb04bdf8 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -2242,6 +2242,8 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_XBGR8888:
 	case DRM_FORMAT_ARGB8888:
 	case DRM_FORMAT_ABGR8888:
+	case DRM_FORMAT_XRGB16161616F:
+	case DRM_FORMAT_ARGB16161616F:
 		if (intel_fb_is_ccs_modifier(modifier))
 			return true;
 		fallthrough;
@@ -2266,8 +2268,6 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_C8:
 	case DRM_FORMAT_XBGR16161616F:
 	case DRM_FORMAT_ABGR16161616F:
-	case DRM_FORMAT_XRGB16161616F:
-	case DRM_FORMAT_ARGB16161616F:
 	case DRM_FORMAT_Y210:
 	case DRM_FORMAT_Y212:
 	case DRM_FORMAT_Y216:
-- 
2.17.1


  parent reply	other threads:[~2024-06-05  5:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 10:23 [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Melanie Lobo
2023-10-11 10:21 ` Jani Nikula
2023-10-11 10:35   ` Lobo, Melanie
2023-10-12  4:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-10-12  6:26 ` [Intel-gfx] [PATCH] " Melanie Lobo
2023-10-12 12:56   ` Ville Syrjälä
2023-10-23  9:15     ` Lobo, Melanie
2023-10-23  9:25   ` Melanie Lobo
2023-10-12 23:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support FP16 compressed formats on MTL (rev3) Patchwork
2023-10-13 21:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-16  5:35 ` [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Dan Carpenter
2023-10-24 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev4) Patchwork
2023-10-24 16:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25  6:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-12-01  9:11 ` [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Melanie Lobo
2023-12-02  0:08   ` Matt Roper
2024-06-03  8:37     ` Lobo, Melanie
2023-12-01 19:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev5) Patchwork
2023-12-01 19:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-12-03  3:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2024-06-03  8:47 ` [PATCH] drm/i915: Support RGB16161616_64B compressed formats Melanie Lobo
2024-06-03 10:29 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev6) Patchwork
2024-06-03 10:44 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-03 23:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-05  5:58 ` [PATCH] drm/i915: Support RGB16161616_64B compressed formats Melanie Lobo
2024-06-05  6:04 ` Melanie Lobo [this message]
2024-07-05 14:35   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605060457.10086-1-melanie.lobo@intel.com \
    --to=melanie.lobo@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=swati2.sharma@intel.com \
    --cc=vidya.srinivas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox