From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH 07/13] drm/i915/alpm: Share alpm support checks with PSR code
Date: Fri, 7 Jun 2024 16:49:11 +0300 [thread overview]
Message-ID: <20240607134917.1327574-8-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240607134917.1327574-1-jouni.hogander@intel.com>
Convert intel_alpm_aux_wake_supported and
intel_alpm_aux_less_wake_supported as non-static. Use them in intel_psr.c
instead of local variables.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++--
drivers/gpu/drm/i915/display/intel_alpm.h | 2 ++
drivers/gpu/drm/i915/display/intel_psr.c | 14 ++------------
3 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 18c1c5803670..90072f6e3a33 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -11,12 +11,12 @@
#include "intel_dp_aux.h"
#include "intel_psr_regs.h"
-static bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp)
+bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp)
{
return intel_dp->alpm_dpcd & DP_ALPM_CAP;
}
-static bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp)
+bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp)
{
return intel_dp->alpm_dpcd & DP_ALPM_AUX_LESS_CAP;
}
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h
index c82ecc7b4001..d4fb60393c91 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.h
+++ b/drivers/gpu/drm/i915/display/intel_alpm.h
@@ -22,4 +22,6 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
void intel_alpm_configure(struct intel_dp *intel_dp,
const struct intel_crtc_state *crtc_state);
void intel_alpm_lobf_debugfs_add(struct intel_connector *connector);
+bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp);
+bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp);
#endif
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 3cc38ba2f954..a3ad4488fcee 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -446,16 +446,6 @@ void intel_psr_irq_handler(struct intel_dp *intel_dp, u32 psr_iir)
}
}
-static bool intel_dp_get_alpm_status(struct intel_dp *intel_dp)
-{
- u8 alpm_caps = 0;
-
- if (drm_dp_dpcd_readb(&intel_dp->aux, DP_RECEIVER_ALPM_CAP,
- &alpm_caps) != 1)
- return false;
- return alpm_caps & DP_ALPM_CAP;
-}
-
static u8 intel_dp_get_sink_sync_latency(struct intel_dp *intel_dp)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
@@ -600,7 +590,6 @@ static void _psr_init_dpcd(struct intel_dp *intel_dp)
intel_dp->psr_dpcd[0] >= DP_PSR2_WITH_Y_COORD_IS_SUPPORTED) {
bool y_req = intel_dp->psr_dpcd[1] &
DP_PSR2_SU_Y_COORDINATE_REQUIRED;
- bool alpm = intel_dp_get_alpm_status(intel_dp);
/*
* All panels that supports PSR version 03h (PSR2 +
@@ -613,7 +602,8 @@ static void _psr_init_dpcd(struct intel_dp *intel_dp)
* Y-coordinate requirement panels we would need to enable
* GTC first.
*/
- intel_dp->psr.sink_psr2_support = y_req && alpm;
+ intel_dp->psr.sink_psr2_support = y_req &&
+ intel_alpm_aux_wake_supported(intel_dp);
drm_dbg_kms(&i915->drm, "PSR2 %ssupported\n",
intel_dp->psr.sink_psr2_support ? "" : "not ");
}
--
2.34.1
next prev parent reply other threads:[~2024-06-07 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 13:49 [PATCH 00/13] Panel Replay eDP prepare Jouni Högander
2024-06-07 13:49 ` [PATCH 01/13] drm/i915/alpm: Do not use fast_wake_lines for aux less wake time Jouni Högander
2024-06-07 13:49 ` [PATCH 02/13] drm/i915/alpm: Write also AUX Less Wake lines into ALPM_CTL Jouni Högander
2024-06-07 13:49 ` [PATCH 03/13] drm/i915/display: Take panel replay into account in vsc sdp unpacking Jouni Högander
2024-06-07 13:49 ` [PATCH 04/13] drm/i915/display: Skip Panel Replay on pipe comparison if no active planes Jouni Högander
2024-06-07 13:49 ` [PATCH 05/13] drm/display: Add missing Panel Replay Enable SU Region ET bit Jouni Högander
2024-06-11 9:55 ` Maarten Lankhorst
2024-06-07 13:49 ` [PATCH 06/13] drm/i915/psr: Split enabling sink for PSR and Panel Replay Jouni Högander
2024-06-07 13:49 ` Jouni Högander [this message]
2024-06-07 13:49 ` [PATCH 08/13] drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid Jouni Högander
2024-06-07 13:49 ` [PATCH 09/13] drm/i915/psr: Print Panel Replay status instead of frame lock status Jouni Högander
2024-06-07 13:49 ` [PATCH 10/13] drm/i915/psr: Move vblank length check to separate function Jouni Högander
2024-06-07 13:49 ` [PATCH 11/13] drm/i915/psr: Take into account SU SDP scanline indication in vblank check Jouni Högander
2024-06-07 13:49 ` [PATCH 12/13] drm/i915/psr: Check vblank against IO buffer wake time on Lunarlake Jouni Högander
2024-06-07 13:49 ` [PATCH 13/13] drm/i915/psr: Wake time is aux less wake time for Panel Replay Jouni Högander
2024-06-07 14:31 ` ✗ Fi.CI.CHECKPATCH: warning for Panel Replay eDP prepare Patchwork
2024-06-07 14:31 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-06-07 14:40 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-07 23:41 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-11 10:14 ` Hogander, Jouni
2024-06-10 9:30 ` [PATCH 00/13] " Manna, Animesh
2024-06-11 10:20 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607134917.1327574-8-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox