Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	jouni.hogander@intel.com, arun.r.murthy@intel.com,
	ankit.k.nautiyal@intel.com,
	mitulkumar.ajitkumar.golani@intel.com,
	Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v8 2/2] drm/i915/display: Set Context Latency at least 1 for psr1/psr2 during vrr
Date: Tue,  2 Jul 2024 11:26:31 +0530	[thread overview]
Message-ID: <20240702055631.3722013-2-animesh.manna@intel.com> (raw)
In-Reply-To: <20240702055631.3722013-1-animesh.manna@intel.com>

Bspec: 71956

The SCL window (i.e. Window 2) must be non-zero if using
VRR + PSR1/PSR2/PR.

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index cdab71f81eaa..05462af6805f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3946,12 +3946,12 @@ void intel_crtc_adjust_vblank_delay(struct intel_crtc_state *crtc_state,
 	/*
 	 * wa_14015401596 for display versions 13, 14.
 	 * Program Set Context Latency in TRANS_SET_CONTEXT_LATENCY register
-	 * to at least a value of 1 when Panel Replay is enabled with VRR.
+	 * to at least a value of 1 when PSR1/PSR2/Panel Replay is enabled with VRR.
 	 * Value for TRANS_SET_CONTEXT_LATENCY is calculated by substracting
 	 * crtc_vdisplay from crtc_vblank_start, so incrementing crtc_vblank_start
 	 * by 1 if both are equal.
 	 */
-	if (crtc_state->vrr.enable && crtc_state->has_panel_replay &&
+	if (crtc_state->vrr.enable && crtc_state->has_psr &&
 	    adjusted_mode->crtc_vblank_start == adjusted_mode->crtc_vdisplay &&
 	    IS_DISPLAY_VER(to_i915(crtc->base.dev), 13, 14))
 		adjusted_mode->crtc_vblank_start += 1;
-- 
2.29.0


  reply	other threads:[~2024-07-02  6:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  5:56 [PATCH v8 1/2] drm/i915/panelreplay: Panel replay workaround with VRR Animesh Manna
2024-07-02  5:56 ` Animesh Manna [this message]
2024-07-02  8:00   ` [PATCH v8 2/2] drm/i915/display: Set Context Latency at least 1 for psr1/psr2 during vrr Hogander, Jouni
2024-07-02  8:09 ` [PATCH v8 1/2] drm/i915/panelreplay: Panel replay workaround with VRR Jani Nikula
2024-07-02  8:42   ` Manna, Animesh
2024-07-02  8:50     ` Jani Nikula
2024-07-02  9:24 ` ✗ Fi.CI.SPARSE: warning for series starting with [v8,1/2] " Patchwork
2024-07-02  9:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-02 20:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-03 13:15 ` [PATCH v8 1/2] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240702055631.3722013-2-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jouni.hogander@intel.com \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox