From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Jann Horn <jannh@google.com>,
Chris Wilson <chris.p.wilson@linux.intel.com>,
Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
Andi Shyti <andi.shyti@linux.intel.com>
Subject: [PATCH v2 1/2] drm/i915/gem: Adjust vma offset for framebuffer mmap offset
Date: Mon, 5 Aug 2024 11:25:53 +0100 [thread overview]
Message-ID: <20240805102554.154464-2-andi.shyti@linux.intel.com> (raw)
In-Reply-To: <20240805102554.154464-1-andi.shyti@linux.intel.com>
When mapping a framebuffer object, the virtual memory area (VMA)
offset ('vm_pgoff') should be adjusted by the start of the
'vma_node' associated with the object. This ensures that the VMA
offset is correctly aligned with the corresponding offset within
the GGTT aperture.
Increment vm_pgoff by the start of the vma_node with the offset=
provided by the user.
Suggested-by: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index a2195e28b625..ce10dd259812 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -1084,6 +1084,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj, struct vm_area_struct *vma
mmo = mmap_offset_attach(obj, mmap_type, NULL);
if (IS_ERR(mmo))
return PTR_ERR(mmo);
+
+ vma->vm_pgoff += drm_vma_node_start(&mmo->vma_node);
}
/*
--
2.45.2
next prev parent reply other threads:[~2024-08-05 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:25 [PATCH v2 0/2] Fix mmap memory boundary calculation Andi Shyti
2024-08-05 10:25 ` Andi Shyti [this message]
2024-08-05 10:25 ` [PATCH v2 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation Andi Shyti
2024-08-05 11:17 ` ✗ Fi.CI.CHECKPATCH: warning for Fix mmap memory boundary calculation (rev2) Patchwork
2024-08-05 11:25 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-05 19:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-05 22:05 ` [PATCH v2 0/2] Fix mmap memory boundary calculation Andi Shyti
2024-08-06 6:38 ` Greg Kroah-Hartman
2024-08-06 9:46 ` Andi Shyti
2024-08-06 12:08 ` Joonas Lahtinen
2024-08-09 14:48 ` Jann Horn
2024-08-09 15:40 ` Jann Horn
2024-08-12 9:18 ` Joonas Lahtinen
2024-08-12 12:30 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805102554.154464-2-andi.shyti@linux.intel.com \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chris.p.wilson@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jannh@google.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=krzysztof.niemiec@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox