From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Arun R Murthy <arun.r.murthy@intel.com>
Subject: [v2PATCH] drm/xe/display: Change HPD to polling on runtime suspend
Date: Thu, 8 Aug 2024 11:26:52 +0530 [thread overview]
Message-ID: <20240808055652.3182460-1-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20240806085513.3051107-1-arun.r.murthy@intel.com>
HPD is interrupt based and on runtime suspend change it to polling as
HPD is not a wakeup event. A worker thread is scheduled for doing this
polling and it keeps polling for HPD live status on an internval of 10s.
On runtime resume disable polling and fallback to interrupt mechanism.
v2: move poll_enable() to xe_display(Imre)
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/xe/display/xe_display.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 78cccbe28947..989022d21052 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -315,6 +315,10 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
intel_hpd_cancel_work(xe);
+ /* Enable hpd polling on runtime suspend */
+ if (runtime)
+ intel_hpd_poll_enable(xe);
+
intel_suspend_encoders(xe);
intel_opregion_suspend(xe, s2idle ? PCI_D1 : PCI_D3cold);
--
2.25.1
next prev parent reply other threads:[~2024-08-08 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 8:55 [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend Arun R Murthy
2024-08-06 9:31 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-08-06 10:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-06 16:17 ` [PATCH] " kernel test robot
2024-08-06 16:41 ` Imre Deak
2024-08-07 9:15 ` Murthy, Arun R
2024-08-07 14:14 ` Imre Deak
2024-08-08 8:40 ` Jani Nikula
2024-08-08 5:56 ` Arun R Murthy [this message]
2024-08-08 6:28 ` ✗ Fi.CI.BUILD: failure for drm/xe/pm: Change HPD to polling on runtime suspend (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808055652.3182460-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox