Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: airlied@gmail.com, simona@ffwll.ch, lucas.demarchi@intel.com,
	thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com,
	jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	tursulin@ursulin.net, lina@asahilina.net
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com,
	francois.dugast@intel.com, aravind.iddamsetty@linux.intel.com,
	anshuman.gupta@intel.com, andi.shyti@linux.intel.com,
	andriy.shevchenko@linux.intel.com, matthew.d.roper@intel.com,
	Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v5 2/4] drm: Expose wedge recovery methods
Date: Tue, 17 Sep 2024 09:32:33 +0530	[thread overview]
Message-ID: <20240917040235.197019-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20240917040235.197019-1-raag.jadav@intel.com>

Now that we have device wedged event in place, add wedge_recovery sysfs
attribute which will expose recovery methods supported by the DRM device.
This is useful for userspace consumers in cases where the device supports
multiple recovery methods which can be used as fallbacks.

$ cat /sys/class/drm/card0/wedge_recovery
rebind
bus-reset
reboot

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/gpu/drm/drm_sysfs.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index fb3bbb6adcd1..b88cdbfa3b5e 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -36,6 +36,8 @@
 #define to_drm_minor(d) dev_get_drvdata(d)
 #define to_drm_connector(d) dev_get_drvdata(d)
 
+extern const char *const wedge_recovery_opts[];
+
 /**
  * DOC: overview
  *
@@ -508,6 +510,26 @@ void drm_sysfs_connector_property_event(struct drm_connector *connector,
 }
 EXPORT_SYMBOL(drm_sysfs_connector_property_event);
 
+static ssize_t wedge_recovery_show(struct device *device,
+				   struct device_attribute *attr, char *buf)
+{
+	struct drm_minor *minor = to_drm_minor(device);
+	struct drm_device *dev = minor->dev;
+	int opt, count = 0;
+
+	for_each_set_bit(opt, &dev->wedge_recovery, DRM_WEDGE_RECOVERY_MAX)
+		count += sysfs_emit_at(buf, count, "%s\n", wedge_recovery_opts[opt]);
+
+	return count;
+}
+static DEVICE_ATTR_RO(wedge_recovery);
+
+static struct attribute *minor_dev_attrs[] = {
+	&dev_attr_wedge_recovery.attr,
+	NULL
+};
+ATTRIBUTE_GROUPS(minor_dev);
+
 struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
 {
 	const char *minor_str;
@@ -532,6 +554,7 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
 		kdev->devt = MKDEV(DRM_MAJOR, minor->index);
 		kdev->class = drm_class;
 		kdev->type = &drm_sysfs_device_minor;
+		kdev->groups = minor_dev_groups;
 	}
 
 	kdev->parent = minor->dev->dev;
-- 
2.34.1


  parent reply	other threads:[~2024-09-17  4:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17  4:02 [PATCH v5 0/4] Introduce DRM device wedged event Raag Jadav
2024-09-17  4:02 ` [PATCH v5 1/4] drm: Introduce " Raag Jadav
2024-09-19  7:43   ` Jani Nikula
2024-09-17  4:02 ` Raag Jadav [this message]
2024-09-17  7:49   ` [PATCH v5 2/4] drm: Expose wedge recovery methods Jani Nikula
2024-09-19  4:05     ` Raag Jadav
2024-09-19  7:38       ` Jani Nikula
2024-09-19  8:38         ` Raag Jadav
2024-09-19  9:24           ` Jani Nikula
2024-09-19 11:33             ` Raag Jadav
2024-09-19 11:39               ` Jani Nikula
2024-09-19 13:45           ` Andy Shevchenko
2024-09-20 11:18             ` Raag Jadav
2024-09-20 14:27               ` Andy Shevchenko
2024-09-17  4:02 ` [PATCH v5 3/4] drm/xe: Use device wedged event Raag Jadav
2024-09-17  4:41   ` Ghimiray, Himal Prasad
2024-09-17  6:38     ` Raag Jadav
2024-09-17  8:03       ` Ghimiray, Himal Prasad
2024-09-17  8:18         ` Aravind Iddamsetty
2024-09-17  4:02 ` [PATCH v5 4/4] drm/i915: " Raag Jadav
2024-09-17  4:53 ` ✗ Fi.CI.CHECKPATCH: warning for Introduce DRM device wedged event (rev3) Patchwork
2024-09-17  4:53 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-17  5:13 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-17 12:23 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240917040235.197019-3-raag.jadav@intel.com \
    --to=raag.jadav@intel.com \
    --cc=airlied@gmail.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francois.dugast@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lina@asahilina.net \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox