From: Raag Jadav <raag.jadav@intel.com>
To: airlied@gmail.com, simona@ffwll.ch, lucas.demarchi@intel.com,
thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com,
jani.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
lina@asahilina.net
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com,
francois.dugast@intel.com, aravind.iddamsetty@linux.intel.com,
anshuman.gupta@intel.com, andi.shyti@linux.intel.com,
matthew.d.roper@intel.com, Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v7 2/5] drm: Expose wedge recovery methods
Date: Mon, 30 Sep 2024 13:08:42 +0530 [thread overview]
Message-ID: <20240930073845.347326-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20240930073845.347326-1-raag.jadav@intel.com>
Now that we have device wedged event in place, add wedge_recovery sysfs
attribute which will expose recovery methods supported by the DRM device.
This is useful for userspace consumers in cases where the device supports
multiple recovery methods which can be used as fallbacks.
$ cat /sys/class/drm/card<N>/wedge_recovery
rebind
bus-reset
reboot
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/drm_sysfs.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index fb3bbb6adcd1..bd77b35ceb8a 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -24,6 +24,7 @@
#include <drm/drm_accel.h>
#include <drm/drm_connector.h>
#include <drm/drm_device.h>
+#include <drm/drm_drv.h>
#include <drm/drm_file.h>
#include <drm/drm_modes.h>
#include <drm/drm_print.h>
@@ -508,6 +509,26 @@ void drm_sysfs_connector_property_event(struct drm_connector *connector,
}
EXPORT_SYMBOL(drm_sysfs_connector_property_event);
+static ssize_t wedge_recovery_show(struct device *device,
+ struct device_attribute *attr, char *buf)
+{
+ struct drm_minor *minor = to_drm_minor(device);
+ struct drm_device *dev = minor->dev;
+ unsigned int method, count = DRM_WEDGE_RECOVERY_REBIND;
+
+ for_each_set_bit(method, &dev->wedge_recovery, DRM_WEDGE_RECOVERY_MAX)
+ count += sysfs_emit_at(buf, count, "%s\n", drm_wedge_recovery_name(method));
+
+ return count;
+}
+static DEVICE_ATTR_RO(wedge_recovery);
+
+static struct attribute *minor_dev_attrs[] = {
+ &dev_attr_wedge_recovery.attr,
+ NULL
+};
+ATTRIBUTE_GROUPS(minor_dev);
+
struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
{
const char *minor_str;
@@ -532,6 +553,7 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
kdev->devt = MKDEV(DRM_MAJOR, minor->index);
kdev->class = drm_class;
kdev->type = &drm_sysfs_device_minor;
+ kdev->groups = minor_dev_groups;
}
kdev->parent = minor->dev->dev;
--
2.34.1
next prev parent reply other threads:[~2024-09-30 7:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 7:38 [PATCH v7 0/5] Introduce DRM device wedged event Raag Jadav
2024-09-30 7:38 ` [PATCH v7 1/5] drm: Introduce " Raag Jadav
2024-09-30 12:59 ` Andy Shevchenko
2024-10-01 5:08 ` Raag Jadav
2024-10-01 12:07 ` Andy Shevchenko
2024-10-01 14:18 ` Raag Jadav
2024-10-01 14:54 ` Andy Shevchenko
2024-10-01 16:42 ` Raag Jadav
2024-10-01 12:20 ` Michal Wajdeczko
2024-10-03 12:23 ` Raag Jadav
2024-10-08 15:02 ` Raag Jadav
2024-10-10 13:02 ` Lucas De Marchi
2024-10-11 8:47 ` Raag Jadav
2024-10-17 2:47 ` Raag Jadav
2024-10-17 7:59 ` Christian König
2024-10-17 16:43 ` Rodrigo Vivi
2024-10-18 10:58 ` Christian König
2024-10-18 12:46 ` Raag Jadav
2024-10-18 12:54 ` Christian König
2024-10-18 14:09 ` Raag Jadav
2024-10-17 19:16 ` André Almeida
2024-10-18 14:56 ` Rodrigo Vivi
2024-10-18 15:31 ` Alex Deucher
2024-10-18 17:56 ` André Almeida
2024-10-18 21:07 ` Alex Deucher
2024-10-24 17:48 ` Rodrigo Vivi
2024-10-19 19:08 ` Raag Jadav
2024-09-30 7:38 ` Raag Jadav [this message]
2024-09-30 13:01 ` [PATCH v7 2/5] drm: Expose wedge recovery methods Andy Shevchenko
2024-10-01 5:23 ` Raag Jadav
2024-09-30 7:38 ` [PATCH v7 3/5] drm/doc: Document device wedged event Raag Jadav
2024-09-30 7:38 ` [PATCH v7 4/5] drm/xe: Use " Raag Jadav
2024-09-30 7:38 ` [PATCH v7 5/5] drm/i915: " Raag Jadav
2024-09-30 22:48 ` ✗ Fi.CI.CHECKPATCH: warning for Introduce DRM device wedged event (rev5) Patchwork
2024-09-30 22:48 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-30 22:58 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-01 9:54 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930073845.347326-3-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francois.dugast@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lina@asahilina.net \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox