From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v2 02/13] drm/i915: Prepare clear color before wait_for_dependencies()
Date: Mon, 30 Sep 2024 20:04:04 +0300 [thread overview]
Message-ID: <20240930170415.23841-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240930170415.23841-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Read out the clear color as soon as fences and the transient
data flush have finished. There is no need to wait for
all the display specific operations that might still be
going on. This could parallelize things a bit more effectively.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index f7667931f9d9..283e0214c4a3 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7385,6 +7385,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
intel_td_flush(dev_priv);
+ intel_atomic_prepare_plane_clear_colors(state);
+
drm_atomic_helper_wait_for_dependencies(&state->base);
drm_dp_mst_atomic_wait_for_dependencies(&state->base);
intel_atomic_global_state_wait_for_dependencies(state);
@@ -7418,8 +7420,6 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
*/
wakeref = intel_display_power_get(dev_priv, POWER_DOMAIN_DC_OFF);
- intel_atomic_prepare_plane_clear_colors(state);
-
for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
new_crtc_state, i) {
if (intel_crtc_needs_modeset(new_crtc_state) ||
--
2.45.2
next prev parent reply other threads:[~2024-09-30 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:04 [PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 01/13] drm/i915/dsb: Avoid reads of the DSB buffer for indexed register writes Ville Syrjala
2024-09-30 17:04 ` Ville Syrjala [this message]
2024-09-30 17:04 ` [PATCH v2 03/13] drm/i915/dsb: Generate the DSB buffer in commit_tail() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 04/13] drm/i915/dsb: Enable programmable DSB interrupt Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 05/13] drm/i915/dsb: Introduce intel_dsb_vblank_evade() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 06/13] drm/i915/dsb: Introduce intel_dsb_wait_usec() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 07/13] drm/i915/dsb: Introduce intel_dsb_wait_vblanks() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 08/13] drm/i915: Introduce intel_scanlines_to_usecs() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 09/13] drm/i915/dsb: Introduce intel_dsb_wait_vblank_delay() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 10/13] drm/i915: Extract intel_crtc_prepare_vblank_event() Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 11/13] drm/i915: Plumb 'dsb' all way to the plane hooks Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 12/13] drm/i915: Plumb 'dsb' all way to the color commit hooks Ville Syrjala
2024-09-30 17:04 ` [PATCH v2 13/13] drm/i915/dsb: Use DSB for plane/color management updates Ville Syrjala
2024-10-01 22:32 ` ✓ Fi.CI.BAT: success for drm/i915: Use DSB for plane/color management commits (rev2) Patchwork
2024-10-01 22:32 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-10-01 22:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-10-02 21:01 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-03 21:52 ` [PATCH v2 00/13] drm/i915: Use DSB for plane/color management commits Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930170415.23841-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox