From: Thomas Zimmermann <tzimmermann@suse.de>
To: simona@ffwll.ch, airlied@gmail.com, javierm@redhat.com,
jfalempe@redhat.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Danilo Krummrich <dakr@redhat.com>
Subject: [PATCH v2 08/11] drm/nouveau: Suspend and resume clients with client helpers
Date: Wed, 2 Oct 2024 15:04:34 +0200 [thread overview]
Message-ID: <20241002131306.288618-9-tzimmermann@suse.de> (raw)
In-Reply-To: <20241002131306.288618-1-tzimmermann@suse.de>
Replace calls to drm_fb_helper_set_suspend_unlocked() with calls
to the client functions drm_client_dev_suspend() and
drm_client_dev_resume(). Any registered in-kernel client will now
receive suspend and resume events.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Danilo Krummrich <dakr@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_display.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index e2fd561cd23f..619a3efbe8c8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -28,8 +28,8 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client_event.h>
#include <drm/drm_crtc_helper.h>
-#include <drm/drm_fb_helper.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_probe_helper.h>
@@ -804,8 +804,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)
{
struct nouveau_display *disp = nouveau_display(dev);
- /* Disable console. */
- drm_fb_helper_set_suspend_unlocked(dev->fb_helper, true);
+ drm_client_dev_suspend(dev, false);
if (drm_drv_uses_atomic_modeset(dev)) {
if (!runtime) {
@@ -836,8 +835,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)
}
}
- /* Enable console. */
- drm_fb_helper_set_suspend_unlocked(dev->fb_helper, false);
+ drm_client_dev_resume(dev, false);
}
int
--
2.46.0
next prev parent reply other threads:[~2024-10-02 13:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 13:04 [PATCH v2 00/11] drm: Introduce DRM client library Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 01/11] drm/i915: Select DRM_CLIENT_SELECTION Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 02/11] drm/xe: " Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 03/11] drm/fbdev: Select fbdev I/O helpers from modules that require them Thomas Zimmermann
2024-10-04 18:29 ` kernel test robot
2024-10-02 13:04 ` [PATCH v2 04/11] drm/fbdev: Store fbdev module parameters in separate file Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 05/11] drm/client: Move client event handlers to drm_client_event.c Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 06/11] drm/client: Move suspend/resume into DRM client callbacks Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 07/11] drm/amdgpu: Suspend and resume internal clients with client helpers Thomas Zimmermann
2024-10-02 13:04 ` Thomas Zimmermann [this message]
2024-10-02 13:04 ` [PATCH v2 09/11] drm/radeon: Suspend and resume " Thomas Zimmermann
2024-10-02 13:04 ` [PATCH v2 10/11] drm/client: Make client support optional Thomas Zimmermann
2024-10-05 1:34 ` kernel test robot
2024-10-02 13:04 ` [PATCH v2 11/11] drm/client: Add client-lib module Thomas Zimmermann
2024-10-02 15:04 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Introduce DRM client library (rev2) Patchwork
2024-10-02 15:04 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-10-02 15:52 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-03 17:10 ` [PATCH v2 00/11] drm: Introduce DRM client library Jocelyn Falempe
2024-10-03 18:01 ` ✗ Fi.CI.IGT: failure for drm: Introduce DRM client library (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002131306.288618-9-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox