From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tvrtko Ursulin <tursulin@ursulin.net>
Subject: Re: [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.
Date: Wed, 2 Oct 2024 18:25:43 +0200 [thread overview]
Message-ID: <20241002162543.TKbd-8g0@linutronix.de> (raw)
In-Reply-To: <20240628130601.1772849-1-bigeasy@linutronix.de>
On 2024-06-28 14:57:59 [+0200], To intel-gfx@lists.freedesktop.org wrote:
Hi,
> The following patches are from the PREEMPT_RT queue. It is mostly about
> disabling interrupts/preemption which leads to problems. Unfortunately
> DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks
> from within trace points. Making the lock a raw_spinlock_t led to higher
> latencies during video playback
> https://lore.kernel.org/all/20211006164628.s2mtsdd2jdbfyf7g@linutronix.de/
>
> and I'm not sure if I hit the worse case here.
> I tested it on a SandyBridge with built-in i915 by using X, OpenGL and
> playing videos without noticing any warnings. However, some code paths
> were not entered.
> I carry them for some time now and most issues were reported by other
> people and they reported that things work for them since.
These patches were not picked. Did I forget something or was this just
overseen?
Sebastian
next prev parent reply other threads:[~2024-10-02 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 12:57 [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 4/8] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 6/8] drm/i915: Drop the irqs_disabled() check Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 7/8] drm/i915/guc: Consider also RCU depth in busy loop Sebastian Andrzej Siewior
2024-06-28 12:58 ` [PATCH v3 8/8] Revert "drm/i915: Depend on !PREEMPT_RT." Sebastian Andrzej Siewior
2024-06-28 13:35 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PREEMPT_RT related fixups. (rev12) Patchwork
2024-06-28 13:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-06-28 13:43 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-28 14:03 ` Saarinen, Jani
2024-10-02 16:25 ` Sebastian Andrzej Siewior [this message]
2024-10-02 16:58 ` [PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups Ville Syrjälä
2024-10-04 6:49 ` Sebastian Andrzej Siewior
2024-10-04 8:31 ` Ville Syrjälä
2024-10-04 8:45 ` Sebastian Andrzej Siewior
2024-10-04 9:07 ` Ville Syrjälä
2024-10-04 10:44 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002162543.TKbd-8g0@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tglx@linutronix.de \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox