Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, Imre Deak <imre.deak@intel.com>
Subject: [core-for-CI] Revert "ICL HACK: usb/icl: Work around ACPI boottime crash"
Date: Fri, 11 Oct 2024 15:17:29 +0300	[thread overview]
Message-ID: <20241011121729.143932-1-jani.nikula@intel.com> (raw)

This reverts commit 8d16a118950c ("ICL HACK: usb/icl: Work around ACPI
boottime crash").

There shouldn't be any ICL RVP's in CI anymore.

Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/usb/core/usb-acpi.c | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c
index 4c7e862cdf2d..21585ed89ef8 100644
--- a/drivers/usb/core/usb-acpi.c
+++ b/drivers/usb/core/usb-acpi.c
@@ -12,7 +12,6 @@
 #include <linux/acpi.h>
 #include <linux/pci.h>
 #include <linux/usb/hcd.h>
-#include <linux/dmi.h>
 
 #include "hub.h"
 
@@ -190,19 +189,6 @@ static int usb_acpi_add_usb4_devlink(struct usb_device *udev)
 	return 0;
 }
 
-static const struct dmi_system_id intel_icl_broken_acpi[] = {
-	{
-		.ident = "ICL RVP",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "Ice Lake Client Platform"),
-		},
-	},
-
-	{ }
-};
-static bool acpi_connection_type_broken;
-
 /*
  * Private to usb-acpi, all the core needs to know is that
  * port_dev->location is non-zero when it has been set by the firmware.
@@ -218,12 +204,6 @@ usb_acpi_get_connect_type(struct usb_port *port_dev, acpi_handle *handle)
 	struct acpi_pld_info *pld = NULL;
 	acpi_status status;
 
-	/* Work around unknown ACPI instruction error on ICL RVP BIOSes. */
-	if (acpi_connection_type_broken) {
-		port_dev->connect_type = USB_PORT_CONNECT_TYPE_UNKNOWN;
-		return;
-	}
-
 	/*
 	 * According to 9.14 in ACPI Spec 6.2. _PLD indicates whether usb port
 	 * is user visible and _UPC indicates whether it is connectable. If
@@ -394,11 +374,6 @@ static struct acpi_bus_type usb_acpi_bus = {
 
 int usb_acpi_register(void)
 {
-	if (dmi_check_system(intel_icl_broken_acpi)) {
-		pr_info("USB ACPI connection type broken.\n");
-		acpi_connection_type_broken = true;
-	}
-
 	return register_acpi_bus_type(&usb_acpi_bus);
 }
 
-- 
2.39.5


             reply	other threads:[~2024-10-11 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 12:17 Jani Nikula [this message]
2024-10-11 13:46 ` ✓ Fi.CI.BAT: success for Revert "ICL HACK: usb/icl: Work around ACPI boottime crash" Patchwork
2024-10-11 14:49 ` [core-for-CI] " Imre Deak
2024-10-23 20:35   ` Lucas De Marchi
2024-10-24 10:23     ` Jani Nikula
2024-10-12  6:08 ` ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011121729.143932-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox