public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 2/5] drm/i915/adlp+/dp_mst: Align slave transcoder enabling with spec wrt. DDI function
Date: Wed, 30 Oct 2024 21:23:10 +0200	[thread overview]
Message-ID: <20241030192313.4030617-3-imre.deak@intel.com> (raw)
In-Reply-To: <20241030192313.4030617-1-imre.deak@intel.com>

On ADLP+ during modeset enabling configure the DDI function without
enabling it for MST slave transcoders before programming the data and
link M/N values. The DDI function gets enabled separately later in the
transcoder enabling sequence.

Align the code with the spec based on the above.

v2: Move this patch earlier in the series, addressing the DP2
    config fixes for all ADLP+ platforms later.

Bspec: 55424, 54128, 65448, 68849
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 7c16406883594..bf264bd1881b5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -1224,7 +1224,7 @@ static void intel_mst_pre_enable_dp(struct intel_atomic_state *state,
 	if (DISPLAY_VER(dev_priv) < 12 || !first_mst_stream)
 		intel_ddi_enable_transcoder_clock(encoder, pipe_config);
 
-	if (DISPLAY_VER(dev_priv) >= 30 && !first_mst_stream)
+	if (DISPLAY_VER(dev_priv) >= 13 && !first_mst_stream)
 		intel_ddi_config_transcoder_func(encoder, pipe_config);
 
 	intel_dsc_dp_pps_write(&dig_port->base, pipe_config);
-- 
2.44.2


  parent reply	other threads:[~2024-10-30 19:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 19:23 [PATCH v2 0/5] drm/dp_mst: Fix DDI function/DP2 config programming Imre Deak
2024-10-30 19:23 ` [PATCH v2 1/5] drm/i915/ptl/dp_mst: Fix slave transcoder enabling wrt. DDI function Imre Deak
2024-10-31 10:44   ` Luca Coelho
2024-10-31 10:57     ` Imre Deak
2024-10-31 10:59       ` Luca Coelho
2024-10-30 19:23 ` Imre Deak [this message]
2024-10-31 10:49   ` [PATCH v2 2/5] drm/i915/adlp+/dp_mst: Align slave transcoder enabling with spec " Luca Coelho
2024-10-31 11:40     ` Imre Deak
2024-11-06 12:38       ` Luca Coelho
2024-10-30 19:23 ` [PATCH v2 3/5] drm/i915/dp_mst: Add a way to disable the DP2 config Imre Deak
2024-10-31 10:52   ` Luca Coelho
2024-10-31 12:36   ` Jani Nikula
2024-10-31 12:42     ` Imre Deak
2024-10-30 19:23 ` [PATCH v2 4/5] drm/i915/adlp+/dp_mst: Align slave transcoder sequences with spec wrt. " Imre Deak
2024-10-31 10:54   ` Luca Coelho
2024-10-30 19:23 ` [PATCH v2 5/5] drm/i915/adlp+/dp_mst: Align master transcoder disabling " Imre Deak
2024-10-31 10:56   ` Luca Coelho
2024-10-31 11:03     ` Imre Deak
2024-10-30 19:50 ` ✗ Fi.CI.SPARSE: warning for drm/dp_mst: Fix DDI function/DP2 config programming Patchwork
2024-10-30 21:24 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-30 21:47   ` Imre Deak
2024-11-04 10:50     ` Illipilli, TejasreeX
2024-11-04 10:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-04 16:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-06 16:29   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030192313.4030617-3-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox