From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [RFC v1 1/4] drm/i915/scaler: Calculate scaler prefill latency
Date: Tue, 12 Nov 2024 14:20:36 +0530 [thread overview]
Message-ID: <20241112085039.1258860-2-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20241112085039.1258860-1-mitulkumar.ajitkumar.golani@intel.com>
Calculate scaler prefill latency which accounts for time for
each scaler in pipeline.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/display/skl_scaler.c | 39 +++++++++++++++++++++++
drivers/gpu/drm/i915/display/skl_scaler.h | 1 +
2 files changed, 40 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 7dbc99b02eaa..eec4a5f783fa 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -6,6 +6,7 @@
#include "i915_reg.h"
#include "intel_de.h"
#include "intel_display_types.h"
+#include "intel_crtc.h"
#include "intel_fb.h"
#include "skl_scaler.h"
#include "skl_universal_plane.h"
@@ -839,3 +840,41 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
else
scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
}
+
+int skl_calc_scaler_prefill_latency(struct intel_crtc_state *crtc_state)
+{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct intel_plane *plane = to_intel_plane(crtc->base.primary);
+ const struct intel_plane_state *plane_state = to_intel_plane_state(plane->base.state);
+ struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
+ int scaler_prefill_latency[2];
+ int num_scaler_in_use, count, hscale, vscale, tot_scaler_prefill_usec;
+ int hscan_time = DIV_ROUND_UP(crtc_state->hw.adjusted_mode.htotal * 1000,
+ crtc_state->hw.adjusted_mode.crtc_clock);
+
+ for (count = 0; count < crtc->num_scalers; count++)
+ if (scaler_state->scalers[count].in_use)
+ num_scaler_in_use++;
+
+ if (!num_scaler_in_use)
+ return 0;
+
+ if (num_scaler_in_use == 2) {
+ hscale = drm_rect_calc_hscale(&plane_state->uapi.src,
+ &plane_state->uapi.dst,
+ 0, INT_MAX);
+ vscale = drm_rect_calc_vscale(&plane_state->uapi.src,
+ &plane_state->uapi.dst,
+ 0, INT_MAX);
+ scaler_prefill_latency[1] = 4 * hscan_time * hscale * vscale;
+ }
+
+ /*
+ * FIXME : When only 1 scaler used, 1st scaler can be downscale/upscale
+ */
+ scaler_prefill_latency[0] = 4 * hscan_time;
+ tot_scaler_prefill_usec = scaler_prefill_latency[0] + scaler_prefill_latency[1];
+
+ return intel_usecs_to_scanlines(&crtc_state->hw.adjusted_mode,
+ tot_scaler_prefill_usec);
+}
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.h b/drivers/gpu/drm/i915/display/skl_scaler.h
index 63f93ca03c89..cd4d961d3b02 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.h
+++ b/drivers/gpu/drm/i915/display/skl_scaler.h
@@ -34,4 +34,5 @@ void skl_scaler_disable(const struct intel_crtc_state *old_crtc_state);
void skl_scaler_get_config(struct intel_crtc_state *crtc_state);
+int skl_calc_scaler_prefill_latency(struct intel_crtc_state *crtc_state);
#endif
--
2.46.0
next prev parent reply other threads:[~2024-11-12 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 8:50 [RFC v1 0/4] Update VRR guardband for HRR panel Mitul Golani
2024-11-12 8:50 ` Mitul Golani [this message]
2024-11-28 9:31 ` [RFC v1 1/4] drm/i915/scaler: Calculate scaler prefill latency Garg, Nemesa
2024-11-12 8:50 ` [RFC v1 2/4] drm/i915/watermark: Add WM0 " Mitul Golani
2024-11-12 8:50 ` [RFC v1 3/4] drm/i915/psr: Add latency for PSR Mitul Golani
2024-11-12 8:50 ` [RFC v1 4/4] display/vrr: Update guardband based on enabled latency Mitul Golani
2024-11-12 10:51 ` ✗ Fi.CI.SPARSE: warning for Update VRR guardband for HRR panel Patchwork
2024-11-12 11:05 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-22 7:53 ` [RFC v1 0/4] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112085039.1258860-2-mitulkumar.ajitkumar.golani@intel.com \
--to=mitulkumar.ajitkumar.golani@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox