From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: intel-gfx@lists.freedesktop.org, john.c.harrison@intel.com
Subject: [PATCH 3/3] i915/guc: Accumulate active runtime on gt reset
Date: Mon, 18 Nov 2024 15:22:23 -0800 [thread overview]
Message-ID: <20241118232223.53639-4-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20241118232223.53639-1-umesh.nerlige.ramappa@intel.com>
On gt reset, if a context is running, then accumulate it's active time
into the busyness counter since there will be no chance for the context
to switch out and update it's run time.
Fixes: 77cdd054dd2c ("drm/i915/pmu: Connect engine busyness stats from GuC to pmu")
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 56be9f385270..0c204b7f3b2b 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1449,8 +1449,21 @@ static void __reset_guc_busyness_stats(struct intel_guc *guc)
guc_update_pm_timestamp(guc, &unused);
for_each_engine(engine, gt, id) {
+ struct intel_engine_guc_stats *stats = &engine->stats.guc;
+
guc_update_engine_gt_clks(engine);
- engine->stats.guc.prev_total = 0;
+
+ if (stats->running) {
+ u64 clk = guc->timestamp.gt_stamp - stats->start_gt_clk;
+
+ /*
+ * If resetting a running context, accumulate the active
+ * time as well since there will be no context switch.
+ */
+ stats->total_gt_clks += clk;
+ }
+ stats->prev_total = 0;
+ stats->running = 0;
}
spin_unlock_irqrestore(&guc->timestamp.lock, flags);
--
2.34.1
next prev parent reply other threads:[~2024-11-18 23:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 23:22 [PATCH 0/3] Fix some races/bugs in GuC engine busyness Umesh Nerlige Ramappa
2024-11-18 23:22 ` [PATCH 1/3] i915/guc: Reset engine utilization buffer before registration Umesh Nerlige Ramappa
2024-11-22 0:29 ` John Harrison
2024-11-18 23:22 ` [PATCH 2/3] i915/guc: Ensure busyness counter increases monotonically Umesh Nerlige Ramappa
2024-11-22 0:31 ` John Harrison
2024-11-22 0:34 ` John Harrison
2024-11-25 20:10 ` Umesh Nerlige Ramappa
2024-11-18 23:22 ` Umesh Nerlige Ramappa [this message]
2024-11-22 0:37 ` [PATCH 3/3] i915/guc: Accumulate active runtime on gt reset John Harrison
2024-11-25 20:12 ` Umesh Nerlige Ramappa
2024-11-19 0:04 ` ✗ Fi.CI.SPARSE: warning for Fix some races/bugs in GuC engine busyness Patchwork
2024-11-19 0:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-19 18:46 ` Umesh Nerlige Ramappa
2024-11-19 20:04 ` ✗ Fi.CI.SPARSE: warning for Fix some races/bugs in GuC engine busyness (rev2) Patchwork
2024-11-19 20:18 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-21 8:38 ` ✗ Fi.CI.SPARSE: warning for Fix some races/bugs in GuC engine busyness (rev3) Patchwork
2024-11-24 9:47 ` ✗ i915.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-11-27 17:40 [PATCH 0/3] Fix some races/bugs in GuC engine busyness Umesh Nerlige Ramappa
2024-11-27 17:40 ` [PATCH 3/3] i915/guc: Accumulate active runtime on gt reset Umesh Nerlige Ramappa
2024-12-05 22:11 ` John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118232223.53639-4-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox