From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>
Subject: [PATCH 6/7] drm/dp_mst: Reset message rx state after OOM in drm_dp_mst_handle_up_req()
Date: Tue, 3 Dec 2024 18:02:22 +0200 [thread overview]
Message-ID: <20241203160223.2926014-7-imre.deak@intel.com> (raw)
In-Reply-To: <20241203160223.2926014-1-imre.deak@intel.com>
After an out-of-memory error the reception state should be reset, so
that the next attempt receiving a message doesn't fail (due to getting a
start-of-message packet, while the reception state has already the
start-of-message flag set).
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index df37fde82d27c..d6452a15daf6a 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -4107,6 +4107,7 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr)
{
struct drm_dp_pending_up_req *up_req;
struct drm_dp_mst_branch *mst_primary;
+ int ret = 0;
if (!drm_dp_get_one_sb_msg(mgr, true, NULL))
goto out_clear_reply;
@@ -4115,8 +4116,10 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr)
return 0;
up_req = kzalloc(sizeof(*up_req), GFP_KERNEL);
- if (!up_req)
- return -ENOMEM;
+ if (!up_req) {
+ ret = -ENOMEM;
+ goto out_clear_reply;
+ }
INIT_LIST_HEAD(&up_req->next);
@@ -4182,7 +4185,7 @@ static int drm_dp_mst_handle_up_req(struct drm_dp_mst_topology_mgr *mgr)
drm_dp_mst_topology_put_mstb(mst_primary);
out_clear_reply:
memset(&mgr->up_req_recv, 0, sizeof(struct drm_dp_sideband_msg_rx));
- return 0;
+ return ret;
}
static void update_msg_rx_state(struct drm_dp_mst_topology_mgr *mgr)
--
2.44.2
next prev parent reply other threads:[~2024-12-03 16:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 16:02 [PATCH 0/7] drm/dp_mst: Fix a few side-band message handling issues Imre Deak
2024-12-03 16:02 ` [PATCH 1/7] drm/dp_mst: Fix resetting msg rx state after topology removal Imre Deak
2024-12-03 16:02 ` [PATCH 2/7] drm/dp_mst: Verify request type in the corresponding down message reply Imre Deak
2024-12-03 16:02 ` [PATCH 3/7] drm/dp_mst: Simplify error path in drm_dp_mst_handle_down_rep() Imre Deak
2024-12-03 16:02 ` [PATCH 4/7] drm/dp_mst: Fix down request message timeout handling Imre Deak
2024-12-03 17:46 ` [PATCH v2 " Imre Deak
2024-12-03 16:02 ` [PATCH 5/7] drm/dp_mst: Ensure mst_primary pointer is valid in drm_dp_mst_handle_up_req() Imre Deak
2024-12-04 13:20 ` [PATCH v2 " Imre Deak
2024-12-03 16:02 ` Imre Deak [this message]
2024-12-03 16:02 ` [PATCH 7/7] drm/dp_mst: Use reset_msg_rx_state() instead of open coding it Imre Deak
2024-12-03 16:34 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Fix a few side-band message handling issues Patchwork
2024-12-03 16:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-12-03 16:50 ` ✗ i915.CI.BAT: failure " Patchwork
2024-12-03 17:07 ` Imre Deak
2024-12-04 6:09 ` Ravali, JupallyX
2024-12-03 18:03 ` [PATCH 0/7] " Lyude Paul
2024-12-03 18:28 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Fix a few side-band message handling issues (rev2) Patchwork
2024-12-03 18:28 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-12-03 18:44 ` ✗ i915.CI.BAT: failure " Patchwork
2024-12-04 6:05 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-04 7:17 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-04 14:07 ` ✗ Fi.CI.CHECKPATCH: warning for drm/dp_mst: Fix a few side-band message handling issues (rev3) Patchwork
2024-12-04 14:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-12-04 14:22 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-04 15:30 ` ✓ i915.CI.Full: " Patchwork
2024-12-05 15:16 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203160223.2926014-7-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox