Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Ed Maste <emaste@freebsd.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	chris.p.wilson@intel.com, intel-gfx@lists.freedesktop.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update license on selftest lists to MIT
Date: Wed, 11 Dec 2024 08:24:25 +0100	[thread overview]
Message-ID: <2024121153-shawl-spearman-8e5f@gregkh> (raw)
In-Reply-To: <Z1jMZNgMssHyAzg2@intel.com>

On Tue, Dec 10, 2024 at 06:19:00PM -0500, Rodrigo Vivi wrote:
> On Sun, Dec 08, 2024 at 03:17:27PM +0000, Ed Maste wrote:
> > These two files (i915_live_selftests.h, i915_mock_selftests.h) were
> > introduced in commit 953c7f82eb89 ("drm/i915: Provide a hook for
> > selftests") and are effectively just a list of selftests.
> > 
> > The selftest implementation itself is largely in i915_selftest.c, and
> > uses a MIT license.  Graphics drivers are shared with other operating
> > systems and have long used a permissive license (or dual license) to
> > facilitate this.
> > 
> > The two selftest list files carried no license when introduced in
> > 953c7f82eb89, presumably as they were considered trivial.  Notably the
> > general selftest header i915_selftest.h (which does have non-trivial
> > content) also has an MIT license.
> > 
> > The GPL-2.0 SPDX tag in these two files came from b24413180f56, where
> > Greg Kroah-Hartman added the tag to all files that had no license.  This
> > makes sense in general, but it is clear from the context of the original
> > selftest commit here that these files are a trivial part of an otherwise
> > MIT-licensed patch to a MIT-licensed component, and should have an MIT
> > license.

No, that is not clear, by default, anything without a license gets the
GPL2 license as that is the license of the entire body of code.

> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Chris, do you confirm your intention of MIT and not GPL for these files?
> 
> Cc: Greg KH <gregkh@linuxfoundation.org>
> 
> Greg, is this acceptable?

You need to get a signed-off-by from everyone who has touched these
files, which is not what you have done here :(

good luck!

greg k-h

  reply	other threads:[~2024-12-11  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-08 15:17 [PATCH] drm/i915: Update license on selftest lists to MIT Ed Maste
2024-12-08 16:03 ` ✓ i915.CI.BAT: success for " Patchwork
2024-12-10 23:19 ` [PATCH] " Rodrigo Vivi
2024-12-11  7:24   ` Greg KH [this message]
2024-12-12 15:10     ` Ed Maste
2024-12-13  9:54       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024121153-shawl-spearman-8e5f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=airlied@gmail.com \
    --cc=chris.p.wilson@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emaste@freebsd.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox