Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Cc: Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>
Subject: [PATCH RESEND v2] drm/i915/gt: Log reason for setting TAINT_WARN at reset
Date: Fri, 20 Dec 2024 14:17:14 +0100	[thread overview]
Message-ID: <20241220131714.1309483-1-andi.shyti@linux.intel.com> (raw)

From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

TAINT_WARN is used to notify CI about non-recoverable failures, which
require device to be restarted. In some cases, there is no sufficient
information about the reason for the restart. The test runner is just
killed, and DUT is rebooted, logging only 'probe with driver i915 failed
with error -4' to dmesg.

Printing error to dmesg before TAINT_WARN, would explain why the device
has been restarted, and what caused the malfunction in the first place.

Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
Cc: Andi Shyti <andi.shyti@kernel.org>

Hi,

this patch for some reason did not reach the mailing list and it
missed all the CI premerge tests. I am resending it, this time
with the Changelog and the versioning.

I am leaving it for a few days in order to be reviewed by others,
as well.

Andi

Changelog:
==========
v1 -> v2:
 - Reword the commit log

 drivers/gpu/drm/i915/gt/intel_reset.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index c2fe3fc78e76..aae5a081cb53 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -1113,6 +1113,7 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt)
 		 * Warn CI about the unrecoverable wedged condition.
 		 * Time for a reboot.
 		 */
+		gt_err(gt, "Unrecoverable wedged condition\n");
 		add_taint_for_CI(gt->i915, TAINT_WARN);
 		return false;
 	}
@@ -1264,8 +1265,10 @@ void intel_gt_reset(struct intel_gt *gt,
 	}
 
 	ret = resume(gt);
-	if (ret)
+	if (ret) {
+		gt_err(gt, "Failed to resume (%d)\n", ret);
 		goto taint;
+	}
 
 finish:
 	reset_finish(gt, awake);
@@ -1608,6 +1611,7 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt)
 	set_bit(I915_WEDGED_ON_INIT, &gt->reset.flags);
 
 	/* Wedged on init is non-recoverable */
+	gt_err(gt, "Non-recoverable wedged on init\n");
 	add_taint_for_CI(gt->i915, TAINT_WARN);
 }
 
-- 
2.45.2


             reply	other threads:[~2024-12-20 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 13:17 Andi Shyti [this message]
2024-12-20 13:34 ` [PATCH RESEND v2] drm/i915/gt: Log reason for setting TAINT_WARN at reset Rodrigo Vivi
2024-12-20 14:07 ` ✗ i915.CI.BAT: failure for " Patchwork
2024-12-20 21:16 ` ✗ i915.CI.BAT: failure for drm/i915/gt: Log reason for setting TAINT_WARN at reset (rev2) Patchwork
2024-12-20 22:08 ` ✗ i915.CI.BAT: failure for drm/i915/gt: Log reason for setting TAINT_WARN at reset (rev3) Patchwork
2024-12-21  0:18 ` ✓ i915.CI.BAT: success for drm/i915/gt: Log reason for setting TAINT_WARN at reset (rev4) Patchwork
2024-12-21 21:27 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-23 19:18 ` [PATCH RESEND v2] drm/i915/gt: Log reason for setting TAINT_WARN at reset Andi Shyti
2024-12-24 11:04   ` Raag Jadav
2024-12-24 11:18     ` Raag Jadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241220131714.1309483-1-andi.shyti@linux.intel.com \
    --to=andi.shyti@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox