Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, Imre Deak <imre.deak@intel.com>
Subject: [PATCH] drm/i915/dp: Fix potential infinite loop in 128b/132b SST
Date: Tue,  4 Feb 2025 17:49:25 +0200	[thread overview]
Message-ID: <20250204154925.3001781-1-jani.nikula@intel.com> (raw)

Passing 0 as the step only works when there are other reasons to break
out of the BPP loop in intel_dp_mtp_tu_compute_config(). Otherwise, an
infinite loop might occur. Fix it by explicitly checking for 0 step.

Fixes: ef0a0757bbea ("drm/i915/dp: compute config for 128b/132b SST w/o DSC")
Reported-by: Imre Deak <imre.deak@intel.com>
Closes: https://lore.kernel.org/r/Z6I0knh2Kt5T0JrT@ideak-desk.fi.intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

Note: This needs a backport with (!step) for -rc1.
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 95abc6ea85eb..1587be5cd0a7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -353,6 +353,10 @@ int intel_dp_mtp_tu_compute_config(struct intel_dp *intel_dp,
 
 			break;
 		}
+
+		/* Allow using zero step to indicate one try */
+		if (!bpp_step_x16)
+			break;
 	}
 
 	if (slots < 0) {
-- 
2.39.5


             reply	other threads:[~2025-02-04 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 15:49 Jani Nikula [this message]
2025-02-04 15:52 ` [PATCH] drm/i915/dp: Fix potential infinite loop in 128b/132b SST Imre Deak
2025-02-05 13:41   ` Jani Nikula
2025-02-04 21:20 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-02-05  8:19   ` Jani Nikula
2025-02-05 14:05     ` Ravali, JupallyX
2025-02-05 13:59 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-05 17:48 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204154925.3001781-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox