Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	 intel-xe@lists.freedesktop.org
Cc: "Jani Nikula" <jani.nikula@linux.intel.com>,
	chaitanya.kumar.borah@intel.com, ville.syrjala@intel.com,
	"Arun R Murthy" <arun.r.murthy@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip
Date: Fri, 28 Mar 2025 21:26:24 +0530	[thread overview]
Message-ID: <20250328-asyn-v11-5-a50d13bfea0d@intel.com> (raw)
In-Reply-To: <20250328-asyn-v11-0-a50d13bfea0d@intel.com>

Async flip is not supported with Indexed 8 bit format as it depends on
LUT and can't be updated atomically.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 3b9d3e1620cd882b8a7f9b4c96640e42367248bb..1bcfa5f4fd63442b632655ccaf325a87be78fe21 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -177,7 +177,8 @@ bool intel_plane_needs_physical(struct intel_plane *plane)
 bool intel_plane_can_async_flip(struct intel_plane *plane, u32 format,
 				u64 modifier)
 {
-	if (intel_format_info_is_yuv_semiplanar(drm_format_info(format), modifier))
+	if (intel_format_info_is_yuv_semiplanar(drm_format_info(format), modifier) ||
+	    format == DRM_FORMAT_C8)
 		return false;
 
 	return plane->can_async_flip && plane->can_async_flip(modifier);

-- 
2.25.1


  parent reply	other threads:[~2025-03-28 16:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 15:56 [PATCH v11 0/5] Expose modifiers/formats supported by async flips Arun R Murthy
2025-03-28 15:56 ` [PATCH v11 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC Arun R Murthy
2025-03-28 15:56 ` [PATCH v11 2/5] drm/plane: modify create_in_formats to acommodate async Arun R Murthy
2025-03-28 15:56 ` [PATCH v11 3/5] drm/i915/display: Acomodate format check in intel_plane_can_async_flip() Arun R Murthy
2025-03-31 15:45   ` Ville Syrjälä
2025-03-28 15:56 ` [PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async Arun R Murthy
2025-03-31 15:46   ` Ville Syrjälä
2025-03-28 15:56 ` Arun R Murthy [this message]
2025-03-31 15:47   ` [PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip Ville Syrjälä
2025-03-28 18:28 ` ✗ Fi.CI.SPARSE: warning for Expose modifiers/formats supported by async flips (rev12) Patchwork
2025-03-28 18:50 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-28 22:18 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-31 15:57 ` [PATCH v11 0/5] Expose modifiers/formats supported by async flips Ville Syrjälä
2025-04-01 13:27   ` Kumar, Naveen1
2025-04-01 16:30     ` Ville Syrjälä
2025-04-03 21:11 ` Xaver Hugl
2025-04-07  9:48   ` Murthy, Arun R
2025-04-07 14:21     ` Xaver Hugl
  -- strict thread matches above, loose matches on Subject: below --
2025-03-28 12:45 Arun R Murthy
2025-03-28 12:45 ` [PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip Arun R Murthy
2025-03-28 13:37   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250328-asyn-v11-5-a50d13bfea0d@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox