Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	 intel-xe@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, imre.deak@intel.com,
	 Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH v3 1/3] drm/display/dp: Export fn to calculate link symbol cycles
Date: Thu, 17 Apr 2025 16:22:28 +0530	[thread overview]
Message-ID: <20250417-hblank-v3-1-d3387df7efce@intel.com> (raw)
In-Reply-To: <20250417-hblank-v3-0-d3387df7efce@intel.com>

Unify the function to calculate the link symbol cycles for both dsc and
non-dsc case and export the function so that it can be used in the
respective platform display drivers for other calculations.

v2: unify the fn for both dsc and non-dsc case (Imre)
v3: rename drm_dp_link_symbol_cycles to drm_dp_link_data_symbol_cycles
    retain slice_eoc_cycles as is (Imre)

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 53 +++++++++++++++++----------------
 include/drm/display/drm_dp_helper.h     |  2 ++
 2 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index 57828f2b7b5a0582ca4a6f2a9be2d5909fe8ad24..5ce8ccc3310fb71b39ea5f74c4022474c180f727 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -4392,26 +4392,33 @@ EXPORT_SYMBOL(drm_panel_dp_aux_backlight);
 
 #endif
 
-/* See DP Standard v2.1 2.6.4.4.1.1, 2.8.4.4, 2.8.7 */
-static int drm_dp_link_symbol_cycles(int lane_count, int pixels, int bpp_x16,
-				     int symbol_size, bool is_mst)
-{
-	int cycles = DIV_ROUND_UP(pixels * bpp_x16, 16 * symbol_size * lane_count);
-	int align = is_mst ? 4 / lane_count : 1;
-
-	return ALIGN(cycles, align);
-}
-
-static int drm_dp_link_dsc_symbol_cycles(int lane_count, int pixels, int slice_count,
-					 int bpp_x16, int symbol_size, bool is_mst)
-{
-	int slice_pixels = DIV_ROUND_UP(pixels, slice_count);
-	int slice_data_cycles = drm_dp_link_symbol_cycles(lane_count, slice_pixels,
-							  bpp_x16, symbol_size, is_mst);
+/**
+ * drm_dp_link_data_symbol_cycles - calculate the link symbol count
+ * @lane_coount: DP link lane count
+ * @pixels: horizontal active pixels
+ * @bpp_x16: bits per pixel in .4 binary fixed format
+ * @symbol_size: DP symbol size
+ * @is_mst: is mst or sst
+ * @slice_count: number of slices
+ *
+ * Calculate the link symbol cycles for both dsc and non dsc case and
+ * return the count.
+ */
+int drm_dp_link_data_symbol_cycles(int lane_count, int pixels, int bpp_x16,
+				   int symbol_size, bool is_mst, int slice_count)
+{
+	int slice_pixels = slice_count ? DIV_ROUND_UP(pixels, slice_count) :
+					 pixels;
+	int cycles = DIV_ROUND_UP(slice_pixels * bpp_x16,
+				  (6 * symbol_size * lane_count));
+	int slice_data_cycles = ALIGN(cycles, is_mst ? (4 / lane_count) : 1);
 	int slice_eoc_cycles = is_mst ? 4 / lane_count : 1;
 
-	return slice_count * (slice_data_cycles + slice_eoc_cycles);
+	return slice_count ? (slice_count *
+			      (slice_data_cycles + slice_eoc_cycles)) :
+			      slice_data_cycles;
 }
+EXPORT_SYMBOL(drm_dp_link_data_symbol_cycles);
 
 /**
  * drm_dp_bw_overhead - Calculate the BW overhead of a DP link stream
@@ -4486,15 +4493,9 @@ int drm_dp_bw_overhead(int lane_count, int hactive,
 	WARN_ON((flags & DRM_DP_BW_OVERHEAD_UHBR) &&
 		(flags & DRM_DP_BW_OVERHEAD_FEC));
 
-	if (flags & DRM_DP_BW_OVERHEAD_DSC)
-		symbol_cycles = drm_dp_link_dsc_symbol_cycles(lane_count, hactive,
-							      dsc_slice_count,
-							      bpp_x16, symbol_size,
-							      is_mst);
-	else
-		symbol_cycles = drm_dp_link_symbol_cycles(lane_count, hactive,
-							  bpp_x16, symbol_size,
-							  is_mst);
+	symbol_cycles = drm_dp_link_data_symbol_cycles(lane_count, hactive,
+						       bpp_x16, symbol_size,
+						       is_mst, dsc_slice_count);
 
 	return DIV_ROUND_UP_ULL(mul_u32_u32(symbol_cycles * symbol_size * lane_count,
 					    overhead * 16),
diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
index d9614e2c89397536f44bb7258e894628ae1dccc9..98bbbe98e5bc0ce0f9cdf513b2c5ea90bb5caffb 100644
--- a/include/drm/display/drm_dp_helper.h
+++ b/include/drm/display/drm_dp_helper.h
@@ -971,5 +971,7 @@ int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);
 int drm_dp_max_dprx_data_rate(int max_link_rate, int max_lanes);
 
 ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp *sdp);
+int drm_dp_link_data_symbol_cycles(int lane_count, int pixels, int bpp_x16,
+				   int symbol_size, bool is_mst, int slice_count);
 
 #endif /* _DRM_DP_HELPER_H_ */

-- 
2.25.1


  reply	other threads:[~2025-04-17 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 10:52 [PATCH v3 0/3] Rework/Correction on minimum hblank calculation Arun R Murthy
2025-04-17 10:52 ` Arun R Murthy [this message]
2025-04-22  5:03   ` [PATCH v3 1/3] drm/display/dp: Export fn to calculate link symbol cycles Kandpal, Suraj
2025-04-22 10:54     ` Imre Deak
2025-04-22  9:33   ` Imre Deak
2025-04-17 10:52 ` [PATCH v3 2/3] drm/i915/display: export function to count dsc slices Arun R Murthy
2025-04-17 10:52 ` [PATCH v3 3/3] drm/i915/display: move min_hblank from dp_mst.c to dp.c Arun R Murthy
2025-04-21 22:47   ` Govindapillai, Vinod
2025-04-22  4:49     ` Murthy, Arun R
2025-04-22  7:25       ` Govindapillai, Vinod
2025-04-22 12:39         ` Imre Deak
2025-04-22  5:28   ` Kandpal, Suraj
2025-04-22 14:22     ` Imre Deak
2025-04-17 11:40 ` ✗ Fi.CI.BUILD: failure for Rework/Correction on minimum hblank calculation (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250417-hblank-v3-1-d3387df7efce@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox