Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: animesh.manna@intel.com, suraj.kandpal@intel.com,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 0/2] ALPM rework and fixes
Date: Tue, 13 May 2025 08:48:12 +0300	[thread overview]
Message-ID: <20250513054814.3702977-1-jouni.hogander@intel.com> (raw)

Currently there are couple of problems in ALPM implelementation:

1. ALPM registers are written while PSR/ Panel Replay is kept
   enabled. This is causing following error messages on PTL:
   
   "xe 0000:00:02.0: [drm] *ERROR* Timeout waiting for DDI BUF A to
   get active".

   This is fixed by enabling ALPM only once when needed.

2. ALPM is never disabled when used by PSR/Panel Replay. I.e. if PSR
   is once enabled ALPM is left enabled for good when PSR is
   disabled. This is fixed by using intel_alpm_disable and calling it
   for both cases: LOBF disable and PSR disable.

This patch set is addressing these.

v4:
  - do not add kerneldoc comments
  - improve comment on intel_psr_panel_replay_enable_sink call
v3:
  - enable/disable ALPM from PSR code
v2:
  - continue using rmw when disabling ALPM
  - take into account disabled hw in old_crtc_state

Jouni Högander (2):
  drm/i915/alpm: Make intel_alpm_enable_sink available for PSR
  drm/i915/alpm: Stop writing ALPM registers when PSR is enabled

 drivers/gpu/drm/i915/display/intel_alpm.c |  8 ++++----
 drivers/gpu/drm/i915/display/intel_alpm.h |  2 ++
 drivers/gpu/drm/i915/display/intel_psr.c  | 13 ++++++++++---
 3 files changed, 16 insertions(+), 7 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-05-13  5:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  5:48 Jouni Högander [this message]
2025-05-13  5:48 ` [PATCH v4 1/2] drm/i915/alpm: Make intel_alpm_enable_sink available for PSR Jouni Högander
2025-05-13  5:48 ` [PATCH v4 2/2] drm/i915/alpm: Stop writing ALPM registers when PSR is enabled Jouni Högander
2025-05-13  6:01   ` Kandpal, Suraj
2025-05-14  9:12     ` Hogander, Jouni
2025-05-13  6:35 ` ✗ Fi.CI.SPARSE: warning for ALPM rework and fixes (rev4) Patchwork
2025-05-13  6:59 ` ✓ i915.CI.BAT: success " Patchwork
2025-05-13  8:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-05-14  9:09   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513054814.3702977-1-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox