From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com, ville.syrjala@linux.intel.com,
khaled.almahallawy@intel.com, Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH] drm/i915/display: Fix RGB limited range handling for DP
Date: Tue, 1 Jul 2025 13:47:56 +0530 [thread overview]
Message-ID: <20250701081756.2821286-1-uma.shankar@intel.com> (raw)
RGB limited range should be selected only if explicitly asked by
userspace by the broadcast RGB property with LIMITED_RANGE. This
is mostly enabled in case of CEA modes.
Display port by default uses Full Range, fixed the same. This will help
set correct MSA information for colorimetry. Fixes a CTS issue wrt
colorimetry.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f48912f308df..8758b9d60d5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2708,8 +2708,6 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
{
const struct intel_digital_connector_state *intel_conn_state =
to_intel_digital_connector_state(conn_state);
- const struct drm_display_mode *adjusted_mode =
- &crtc_state->hw.adjusted_mode;
/*
* Our YCbCr output is always limited range.
@@ -2721,18 +2719,13 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
if (crtc_state->output_format != INTEL_OUTPUT_FORMAT_RGB)
return false;
- if (intel_conn_state->broadcast_rgb == INTEL_BROADCAST_RGB_AUTO) {
- /*
- * See:
- * CEA-861-E - 5.1 Default Encoding Parameters
- * VESA DisplayPort Ver.1.2a - 5.1.1.1 Video Colorimetry
- */
- return crtc_state->pipe_bpp != 18 &&
- drm_default_rgb_quant_range(adjusted_mode) ==
- HDMI_QUANTIZATION_RANGE_LIMITED;
- } else {
- return intel_conn_state->broadcast_rgb ==
- INTEL_BROADCAST_RGB_LIMITED;
+ switch (intel_conn_state->broadcast_rgb) {
+ case INTEL_BROADCAST_RGB_LIMITED:
+ return true;
+ case INTEL_BROADCAST_RGB_FULL:
+ case INTEL_BROADCAST_RGB_AUTO:
+ default:
+ return false;
}
}
--
2.42.0
next reply other threads:[~2025-07-01 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 8:17 Uma Shankar [this message]
2025-07-01 8:32 ` [PATCH] drm/i915/display: Fix RGB limited range handling for DP Ville Syrjälä
2025-07-01 14:15 ` Shankar, Uma
2025-07-01 17:38 ` Almahallawy, Khaled
2025-07-02 19:25 ` Ville Syrjälä
2025-07-01 8:53 ` ✓ i915.CI.BAT: success for " Patchwork
2025-07-02 1:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-07-02 8:42 ` [PATCH] " Jani Nikula
2025-07-02 10:21 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701081756.2821286-1-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=khaled.almahallawy@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox