From: Luca Coelho <luciano.coelho@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH v2 7/7] drm/i915/wm: reduce size of y_min_scanlines to u8
Date: Tue, 7 Oct 2025 10:56:41 +0300 [thread overview]
Message-ID: <20251007075729.468669-8-luciano.coelho@intel.com> (raw)
In-Reply-To: <20251007075729.468669-1-luciano.coelho@intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1161 bytes --]
We don't need more than an u8 to represent y_min_scanlines in the
watermark code, so we can convert it from u32 to u8 and use it to fill
one hole in the structure, saving 4 bytes.
Suggested-by: Ville Syrälä <ville.syrjala@linux.intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 4f9fd8c6ccb4..4149b891615e 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -64,16 +64,16 @@ enum wm_tiling_mode {
struct skl_wm_params {
enum wm_tiling_mode tiling;
u32 width;
- u8 cpp;
- bool rc_surface;
- bool is_planar;
u32 plane_pixel_rate;
- u32 y_min_scanlines;
u32 plane_bytes_per_line;
uint_fixed_16_16_t plane_blocks_per_line;
uint_fixed_16_16_t y_tile_minimum;
u32 linetime_us;
u32 dbuf_block_size;
+ u8 cpp;
+ u8 y_min_scanlines;
+ bool rc_surface;
+ bool is_planar;
};
u8 intel_enabled_dbuf_slices_mask(struct intel_display *display)
--
2.51.0
prev parent reply other threads:[~2025-10-07 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 7:56 [PATCH v2 0/7] drm/i915/wm: some clean-ups and a bit of refactoring Luca Coelho
2025-10-07 7:56 ` [PATCH v2 1/7] drm/i915/wm: clarify watermark ops with comments Luca Coelho
2025-10-07 7:56 ` [PATCH v2 2/7] drm/i915/wm: move intel_sagv_init() to avoid forward declaration Luca Coelho
2025-10-07 7:56 ` [PATCH v2 3/7] drm/i915/wm: remove stale FIXME in skl_needs_memory_bw_wa() Luca Coelho
2025-10-07 7:56 ` [PATCH v2 4/7] drm/i915/wm: convert x/y-tiling bools to an enum Luca Coelho
2025-10-07 8:07 ` Jani Nikula
2025-10-07 8:26 ` Luca Coelho
2025-10-10 8:11 ` kernel test robot
2025-10-07 7:56 ` [PATCH v2 5/7] drm/i915/wm: convert tiling mode check in slk_compute_plane_wm() to a switch-case Luca Coelho
2025-10-07 7:56 ` [PATCH v2 6/7] drm/i915/wm: move method selection and calculation to a separate function Luca Coelho
2025-10-07 7:56 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007075729.468669-8-luciano.coelho@intel.com \
--to=luciano.coelho@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox