Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, uma.shankar@intel.com
Subject: [PATCH] drm/i915: move intel_gmch.[ch] from soc/ to display/
Date: Thu, 13 Nov 2025 15:37:50 +0200	[thread overview]
Message-ID: <20251113133751.696625-1-jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1763027774.git.jani.nikula@intel.com>

The sole user of the remaining functions in intel_gmch.[ch] is in
display. Move them under display.

This allows us to remove the compat soc/intel_gmch.h from xe.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Makefile                           | 5 +----
 drivers/gpu/drm/i915/{soc => display}/intel_gmch.c      | 3 +--
 drivers/gpu/drm/i915/{soc => display}/intel_gmch.h      | 0
 drivers/gpu/drm/i915/display/intel_vga.c                | 3 +--
 drivers/gpu/drm/xe/compat-i915-headers/soc/intel_gmch.h | 6 ------
 5 files changed, 3 insertions(+), 14 deletions(-)
 rename drivers/gpu/drm/i915/{soc => display}/intel_gmch.c (95%)
 rename drivers/gpu/drm/i915/{soc => display}/intel_gmch.h (100%)
 delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/soc/intel_gmch.h

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 90588d5bb908..98822c98d960 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -57,10 +57,6 @@ i915-y += \
 	vlv_iosf_sb.o \
 	vlv_suspend.o
 
-# core peripheral code
-i915-y += \
-	soc/intel_gmch.o
-
 # core library code
 i915-y += \
 	i915_memcpy.o \
@@ -280,6 +276,7 @@ i915-y += \
 	display/intel_flipq.o \
 	display/intel_frontbuffer.o \
 	display/intel_global_state.o \
+	display/intel_gmch.o \
 	display/intel_hdcp.o \
 	display/intel_hdcp_gsc.o \
 	display/intel_hdcp_gsc_message.o \
diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.c b/drivers/gpu/drm/i915/display/intel_gmch.c
similarity index 95%
rename from drivers/gpu/drm/i915/soc/intel_gmch.c
rename to drivers/gpu/drm/i915/display/intel_gmch.c
index 30f489417064..7797c7341047 100644
--- a/drivers/gpu/drm/i915/soc/intel_gmch.c
+++ b/drivers/gpu/drm/i915/display/intel_gmch.c
@@ -9,9 +9,8 @@
 #include <drm/drm_print.h>
 #include <drm/intel/i915_drm.h>
 
-#include "../display/intel_display_core.h" /* FIXME */
-
 #include "i915_drv.h"
+#include "intel_display_core.h"
 #include "intel_gmch.h"
 #include "intel_pci_config.h"
 
diff --git a/drivers/gpu/drm/i915/soc/intel_gmch.h b/drivers/gpu/drm/i915/display/intel_gmch.h
similarity index 100%
rename from drivers/gpu/drm/i915/soc/intel_gmch.h
rename to drivers/gpu/drm/i915/display/intel_gmch.h
diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
index 6e125564db34..91ba17965ee3 100644
--- a/drivers/gpu/drm/i915/display/intel_vga.c
+++ b/drivers/gpu/drm/i915/display/intel_vga.c
@@ -11,10 +11,9 @@
 #include <drm/drm_print.h>
 #include <video/vga.h>
 
-#include "soc/intel_gmch.h"
-
 #include "intel_de.h"
 #include "intel_display.h"
+#include "intel_gmch.h"
 #include "intel_vga.h"
 #include "intel_vga_regs.h"
 
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_gmch.h b/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_gmch.h
deleted file mode 100644
index 33c5257b3a71..000000000000
--- a/drivers/gpu/drm/xe/compat-i915-headers/soc/intel_gmch.h
+++ /dev/null
@@ -1,6 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#include "../../../i915/soc/intel_gmch.h"
-- 
2.47.3


  parent reply	other threads:[~2025-11-13 13:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13  9:57 [PATCH 0/8] drm/i915: start dissolving soc/ Jani Nikula
2025-11-13  9:57 ` [PATCH 1/8] drm/i915/edram: extract i915_edram.[ch] for edram detection Jani Nikula
2025-11-13  9:57 ` [PATCH 2/8] drm/i915: split out i915_freq.[ch] Jani Nikula
2025-11-13  9:58 ` [PATCH 3/8] drm/i915: move intel_dram.[ch] from soc/ to display/ Jani Nikula
2025-11-13  9:58 ` [PATCH 4/8] drm/xe: remove MISSING_CASE() from compat i915_utils.h Jani Nikula
2025-11-13  9:58 ` [PATCH 5/8] drm/i915/dram: convert to struct intel_display Jani Nikula
2025-11-13 13:39   ` Ville Syrjälä
2025-11-13 13:45     ` Jani Nikula
2025-11-13  9:58 ` [PATCH 6/8] drm/i915: move dram_info " Jani Nikula
2025-11-13  9:58 ` [PATCH 7/8] drm/i915: move intel_rom.[ch] from soc/ to display/ Jani Nikula
2025-11-13  9:58 ` [PATCH 8/8] drm/xe: remove remaining platform checks from compat i915_drv.h Jani Nikula
2025-11-13 13:29 ` [PATCH 0/8] drm/i915: start dissolving soc/ Jani Nikula
2025-11-13 13:44   ` Jani Nikula
2025-11-13 13:37 ` [PATCH] drm/i915/gmch: split out i915_gmch.[ch] from soc Jani Nikula
2025-11-13 13:37 ` Jani Nikula [this message]
2025-11-13 13:53   ` [PATCH] drm/i915: move intel_gmch.[ch] from soc/ to display/ Ville Syrjälä
2025-11-13 15:22     ` Jani Nikula
2025-11-13 13:37 ` [PATCH] drm/i915/gmch: convert intel_gmch.c to struct intel_display Jani Nikula
2025-11-13 13:38 ` [PATCH] drm/i915/gmch: find bridge device locally Jani Nikula
2025-11-13 15:08   ` Ville Syrjälä
2025-11-13 15:26     ` Jani Nikula
2025-11-13 13:38 ` [PATCH] drm/xe: use the same vga decode code as i915 Jani Nikula
2025-11-14 22:23   ` kernel test robot
2025-11-13 23:21 ` ✗ i915.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251113133751.696625-1-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox