Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
	mitulkumar.ajitkumar.golani@intel.com,
	ankit.k.nautiyal@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH v8 18/18] drm/i915/vrr: Add function to check if DC Balance Possible
Date: Mon, 17 Nov 2025 11:14:42 +0530	[thread overview]
Message-ID: <20251117054442.4047665-19-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20251117054442.4047665-1-mitulkumar.ajitkumar.golani@intel.com>

Add function to check if DC Balance possibile on
requested PIPE and also validate along with DISPLAY_VER
check.

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 87945b031a7d..8aba20a50d92 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -263,11 +263,25 @@ void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state)
 }
 
 static
-void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state,
-				   int vmin, int vmax)
+int intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
+
+	/*
+	 * FIXME: Currently Firmware supports DC Balancing on PIPE A
+	 * and PIPE B. Account those limitation while computing DC
+	 * Balance parameters.
+	 */
+	return (HAS_VRR_DC_BALANCE(display) &&
+		((pipe == PIPE_A) || (pipe == PIPE_B)));
+}
 
+static
+void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state,
+				   int vmin, int vmax)
+{
 	crtc_state->vrr.vmax = vmax;
 	crtc_state->vrr.vmin = vmin;
 	crtc_state->vrr.flipline = crtc_state->vrr.vmin;
@@ -275,7 +289,7 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state,
 	crtc_state->vrr.enable = true;
 	crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
 
-	if (HAS_VRR_DC_BALANCE(display))
+	if (intel_vrr_dc_balance_possible(crtc_state))
 		crtc_state->vrr.dc_balance.enable = true;
 }
 
-- 
2.48.1


  parent reply	other threads:[~2025-11-17  5:45 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  5:44 [PATCH v8 00/18] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-11-17  5:44 ` [PATCH v8 01/18] drm/i915/display: Add source param for dc balance Mitul Golani
2025-11-26  3:16   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 02/18] drm/i915/dmc: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-11-26  3:17   ` Nautiyal, Ankit K
2025-11-26  3:18   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 03/18] drm/i915/vrr: Add VRR DC balance registers Mitul Golani
2025-11-26  3:19   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 04/18] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-11-17  5:44 ` [PATCH v8 05/18] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-11-17  5:44 ` [PATCH v8 06/18] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-11-26  3:21   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 07/18] drm/i915/vrr: Add compute config " Mitul Golani
2025-11-26  4:09   ` Nautiyal, Ankit K
2025-11-26  7:30     ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 08/18] drm/i915/vrr: Add function to reset DC balance accumulated params Mitul Golani
2025-11-26  4:12   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 09/18] drm/i915/display: Add DC Balance flip count operations Mitul Golani
2025-11-26  4:14   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 10/18] drm/i915/vrr: Write DC balance params to hw registers Mitul Golani
2025-11-26  4:25   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 11/18] drm/i915/vblank: Extract vrr_vblank_start() Mitul Golani
2025-11-17  5:44 ` [PATCH v8 12/18] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-11-17  5:44 ` [PATCH v8 13/18] drm/i915/display: Wait for VRR PUSH status update Mitul Golani
2025-11-26  4:29   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 14/18] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-11-17  5:44 ` [PATCH v8 15/18] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-11-17  5:44 ` [PATCH v8 16/18] drm/i915/display: Add function to configure event for dc balance Mitul Golani
2025-11-26  4:32   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 17/18] drm/i915/vrr: Enable DC Balance Mitul Golani
2025-11-26  4:36   ` Nautiyal, Ankit K
2025-11-26  4:45   ` Nautiyal, Ankit K
2025-11-17  5:44 ` Mitul Golani [this message]
2025-11-26  4:37   ` [PATCH v8 18/18] drm/i915/vrr: Add function to check if DC Balance Possible Nautiyal, Ankit K
2025-11-17 10:43 ` ✓ i915.CI.Full: success for Enable/Disable DC balance along with VRR DSB Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117054442.4047665-19-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox