Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Atwood <matthew.s.atwood@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@Intel.com, dnyaneshware.bhdane@intel.com,
	gustavo.sousa@intel.com, jouni.hogander@intel.com,
	juha-peka.heikkila@intel.com, luciano.coelho@intel.com,
	matthew.d.roper@intel.com, ravi.kumar.vodapalli@intel.com,
	shekhar.chauhan@intel.com, vinod.govindapillai@intel.com,
	imre.deak@intel.com, jani.nikula@linux.intel.com,
	suraj.kandapal@intel.com, jani.nikula@intel.com,
	ville.syrjala@linux.intel.com, sai.teja.pottumuttu@Intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v6 6/8] drm/i915/display: Use platform check in HAS_LT_PHY()
Date: Mon,  1 Dec 2025 17:23:04 -0800	[thread overview]
Message-ID: <20251202012306.9315-7-matthew.s.atwood@intel.com> (raw)
In-Reply-To: <20251202012306.9315-1-matthew.s.atwood@intel.com>

From: Gustavo Sousa <gustavo.sousa@intel.com>

NVL uses the Lake Tahoe PHY for display output and the driver recently
added the macro HAS_LT_PHY() to allow selecting code paths specific for
that type of PHY.

While NVL uses Xe3p_LPD as display IP, the type of PHY is actually
defined at the SoC level, so use a platform check instead of display
version.

Bspec: 74199
Cc: Suraj Kandpal <suraj.kandpal@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_lt_phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lt_phy.h b/drivers/gpu/drm/i915/display/intel_lt_phy.h
index b7911acd7dcd..0820968e51b5 100644
--- a/drivers/gpu/drm/i915/display/intel_lt_phy.h
+++ b/drivers/gpu/drm/i915/display/intel_lt_phy.h
@@ -42,6 +42,6 @@ void intel_xe3plpd_pll_enable(struct intel_encoder *encoder,
 			      const struct intel_crtc_state *crtc_state);
 void intel_xe3plpd_pll_disable(struct intel_encoder *encoder);
 
-#define HAS_LT_PHY(display) (DISPLAY_VER(display) >= 35)
+#define HAS_LT_PHY(display) ((display)->platform.novalake)
 
 #endif /* __INTEL_LT_PHY_H__ */
-- 
2.51.0


  parent reply	other threads:[~2025-12-02  1:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02  1:22 [PATCH v6 0/8] drm/i915/display: Add initial support Xe3p_LPD Matt Atwood
2025-12-02  1:22 ` [PATCH v6 1/8] drm/i915/vbt: Add fields dedicated_external and dyn_port_over_tc Matt Atwood
2025-12-02  1:23 ` [PATCH v6 2/8] drm/i915/power: Use intel_encoder_is_tc() Matt Atwood
2025-12-02  1:23 ` [PATCH v6 3/8] drm/i915/display: Handle dedicated external ports in intel_encoder_is_tc() Matt Atwood
2025-12-02  1:23 ` [PATCH v6 4/8] drm/i915/xe3p_lpd: Handle underrun debug bits Matt Atwood
2025-12-02 18:11   ` Matt Roper
2025-12-02  1:23 ` [PATCH v6 5/8] drm/i915/nvls: Add NVL-S display support Matt Atwood
2025-12-02  1:23 ` Matt Atwood [this message]
2025-12-02  1:23 ` [PATCH v6 7/8] drm/i915/display: Move HAS_LT_PHY() to intel_display_device.h Matt Atwood
2025-12-02  1:23 ` [PATCH v6 8/8] drm/i915/display: Use HAS_LT_PHY() for LT PHY AUX power Matt Atwood
2025-12-02  2:07 ` ✓ i915.CI.BAT: success for drm/i915/display: Add initial support Xe3p_LPD Patchwork
2025-12-02  3:26 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251202012306.9315-7-matthew.s.atwood@intel.com \
    --to=matthew.s.atwood@intel.com \
    --cc=ankit.k.nautiyal@Intel.com \
    --cc=dnyaneshwar.bhadane@intel.com \
    --cc=dnyaneshware.bhdane@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=jouni.hogander@intel.com \
    --cc=juha-peka.heikkila@intel.com \
    --cc=luciano.coelho@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=ravi.kumar.vodapalli@intel.com \
    --cc=sai.teja.pottumuttu@Intel.com \
    --cc=shekhar.chauhan@intel.com \
    --cc=suraj.kandapal@intel.com \
    --cc=suraj.kandpal@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox