Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Austin Hu <austin.hu@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com
Subject: [PATCH 3/3] drm/i915/color: Adjust DE version checking for 3D LUT.
Date: Mon,  9 Feb 2026 13:34:22 -0800	[thread overview]
Message-ID: <20260209213422.2640277-3-austin.hu@intel.com> (raw)
In-Reply-To: <20260209213422.2640277-1-austin.hu@intel.com>

To distinguish the valid 3D LUT settings for Intel platforms with
different Display Engine IPs.

Signed-off-by: Austin Hu <austin.hu@intel.com>
---
 drivers/gpu/drm/i915/display/intel_color.c    | 38 +++++++++++--------
 .../drm/i915/display/intel_color_pipeline.c   |  6 +--
 2 files changed, 25 insertions(+), 19 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index dff33c9c1..1e89dc006 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -4106,22 +4106,28 @@ static void glk_lut_3d_commit(struct intel_dsb *dsb,
 	}
 
 	if (enable) {
-		val = LUT_3D_ENABLE | LUT_3D_READY;
-
-		switch (plane->id) {
-		case PLANE_1:
-			val |= LUT_3D_BIND_PLANE_1;
-			break;
-		case PLANE_2:
-			val |= LUT_3D_BIND_PLANE_2;
-			break;
-		case PLANE_3:
-			val |= LUT_3D_BIND_PLANE_3;
-			break;
-		default:
-			/* Attached the 3D LUT block to Pipe. */
-			val |= LUT_3D_BIND_PIPE;
-			break;
+		val = LUT_3D_ENABLE;
+
+		if (DISPLAY_VER(display) >= 30) {
+			val |= LUT_3D_READY;
+
+			if (DISPLAY_VER(display) >= 35) {
+				switch (plane->id) {
+				case PLANE_1:
+					val |= LUT_3D_BIND_PLANE_1;
+					break;
+				case PLANE_2:
+					val |= LUT_3D_BIND_PLANE_2;
+					break;
+				case PLANE_3:
+					val |= LUT_3D_BIND_PLANE_3;
+					break;
+				default:
+					/* Attached the 3D LUT block to Pipe. */
+					val |= LUT_3D_BIND_PIPE;
+					break;
+				}
+			}
 		}
 	}
 
diff --git a/drivers/gpu/drm/i915/display/intel_color_pipeline.c b/drivers/gpu/drm/i915/display/intel_color_pipeline.c
index d26b0f134..e1bf7990c 100644
--- a/drivers/gpu/drm/i915/display/intel_color_pipeline.c
+++ b/drivers/gpu/drm/i915/display/intel_color_pipeline.c
@@ -12,6 +12,7 @@
 #define MAX_COLOR_PIPELINES 1
 #define PLANE_DEGAMMA_SIZE 128
 #define PLANE_GAMMA_SIZE 32
+#define DIM_SIZE_3D_LUT 17
 
 static
 int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enum_list *list,
@@ -47,11 +48,10 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en
 	drm_colorop_set_next_property(prev_op, &colorop->base);
 	prev_op = &colorop->base;
 
-	if ((DISPLAY_VER(display) >= 15) && HAS_3D_LUT(display) &&
-			intel_color_crtc_has_3dlut(display, pipe)) {
+	if (HAS_3D_LUT(display) && intel_color_crtc_has_3dlut(display, pipe)) {
 		colorop = intel_colorop_create(INTEL_PLANE_CB_3DLUT);
 
-		ret = drm_plane_colorop_3dlut_init(dev, &colorop->base, plane, 17,
+		ret = drm_plane_colorop_3dlut_init(dev, &colorop->base, plane, DIM_SIZE_3D_LUT,
 						   DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL,
 						   true);
 		if (ret)
-- 
2.34.1


  parent reply	other threads:[~2026-02-09 21:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 21:34 [PATCH 1/3] drm/i915/color: Add 3D LUT to color pipeline since Lunar Lake Austin Hu
2026-02-09 21:34 ` [PATCH 2/3] drm/i915/color: Attach the 3D LUT block to required DE Plane Austin Hu
2026-02-09 21:34 ` Austin Hu [this message]
2026-02-10 10:05   ` [PATCH 3/3] drm/i915/color: Adjust DE version checking for 3D LUT Jani Nikula
2026-02-09 22:43 ` ✓ i915.CI.BAT: success for series starting with [1/3] drm/i915/color: Add 3D LUT to color pipeline since Lunar Lake Patchwork
2026-02-10  8:32 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-10 10:03 ` [PATCH 1/3] " Jani Nikula
2026-02-10 14:56 ` Borah, Chaitanya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260209213422.2640277-3-austin.hu@intel.com \
    --to=austin.hu@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox