Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, nemesa.garg@intel.com,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH v3 6/9] drm/i915/scaler: remove id in favor of scaler_id
Date: Sat,  9 May 2026 18:40:45 +0200	[thread overview]
Message-ID: <20260509164048.627399-7-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260509164048.627399-1-michal.grzelak@intel.com>

id is not really used anywhere in skl_scaler_get_config(). Replace it
with scaler_id.

Return if no scaler was found.

v1->v2
- check if any scaler was found (Ville)

Cc: Nemesa Garg <nemesa.garg@intel.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index d15e0194ca10..6d9080ec74ce 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -951,7 +951,6 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
 	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
 	struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
 	int scaler_id;
-	int id = -1;
 
 	/* find scaler attached to this pipe */
 	for (scaler_id = 0; scaler_id < crtc->num_scalers; scaler_id++) {
@@ -961,8 +960,6 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
 		if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) != (PS_SCALER_EN | PS_BINDING_PIPE))
 			continue;
 
-		id = scaler_id;
-
 		if (scaler_has_casf(display, scaler_id))
 			intel_casf_sharpness_get_config(crtc_state);
 
@@ -981,8 +978,11 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	scaler_state->scaler_id = id;
-	if (id >= 0)
+	if (scaler_id == crtc->num_scalers)
+		return;
+
+	scaler_state->scaler_id = scaler_id;
+	if (scaler_id >= 0)
 		scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
 	else
 		scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
-- 
2.45.2


  parent reply	other threads:[~2026-05-09 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 16:40 [PATCH v3 0/9] casf & scaler refactoring Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 1/9] drm/i915/casf: fix comment typos Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 2/9] drm/i915/casf: rename *_coef*() into *_coeff*() Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 3/9] drm/i915: rename t into tap Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 4/9] drm/i915/casf: rename sumcoeff into sum_coeff Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 5/9] drm/i915/scaler: s/i/scaler_id/ where appropriate Michał Grzelak
2026-05-09 16:40 ` Michał Grzelak [this message]
2026-05-09 16:40 ` [PATCH v3 7/9] drm/i915/scaler: unloop scaler readout that is run once Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 8/9] drm/i915/scaler: abstract scaler searching loop Michał Grzelak
2026-05-09 16:40 ` [PATCH v3 9/9] drm/i915/scaler: eliminate dead code Michał Grzelak
2026-05-09 17:39 ` ✓ i915.CI.BAT: success for casf & scaler refactoring Patchwork
2026-05-10  4:25 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260509164048.627399-7-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox