From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: suraj.kandpal@intel.com, imre.deak@intel.com,
ville.syrjala@intel.com, Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH] drm/i915/dp: On DPCD read failure skip LT
Date: Mon, 11 May 2026 08:50:07 +0530 [thread overview]
Message-ID: <20260511032007.104081-1-arun.r.murthy@intel.com> (raw)
The commit e42e7e585984 ("drm/i915: Fix modesetting in case of
unexpected AUX timeouts") continue the LT even if DPCD read failed.
But doing so will blot the dmesg with multiple AUX Tx errors, so skip
the LT but continue the modeset seq for the reason said in the above
mentioned patch.
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index a26094223f78..2598e4ba9712 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -1776,9 +1776,12 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
lttpr_count = intel_dp_init_lttpr_and_dprx_caps(intel_dp);
- if (lttpr_count < 0)
- /* Still continue with enabling the port and link training. */
- lttpr_count = 0;
+ if (lttpr_count < 0) {
+ /* skip LT but complete the modeset seq */
+ lt_dbg(intel_dp, DP_PHY_DPRX,
+ "Reading LTTPR/DPRX caps failed, skip LT\n");
+ goto retry;
+ }
intel_dp_prepare_link_train(intel_dp, crtc_state);
@@ -1795,6 +1798,7 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
return;
}
+retry:
intel_dp->link.seq_train_failures++;
/*
--
2.25.1
next reply other threads:[~2026-05-11 3:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 3:20 Arun R Murthy [this message]
2026-05-11 4:20 ` ✓ i915.CI.BAT: success for drm/i915/dp: On DPCD read failure skip LT Patchwork
2026-05-11 7:40 ` [PATCH] " Imre Deak
2026-05-11 12:08 ` ✗ i915.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511032007.104081-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox